rinnocenti / innocenti-looting Goto Github PK

Instead of items that the players aren't meant to receive perhaps a looting tab could be a good idea, kinda like a mod in Minecraft called "Custom NPC" where it has a chance to drop THOSE items instead of what the NPC is carrying/wielding:

Ex:

Thank you!

Hi,

There is a problem with the accents.

Thank you for the module. I run into some problems partially because I couldn't at first figure out how it should work :D

1. Do I need to manually turn every dead enemy in to loot sheet and give players access to them?

Took me a long time to actually figure out how my player can access the loot sheet in the first place, before I understood that I need to switch the sheet to loot sheet. Is there a setting (didn't find) or macro to do this automatically when enemies die?

2. I get an error for no active GM present when trying to loot the enemies.

After getting to the loot sheet, I tried to split the gold three ways and was instantly given a message that there is no active GM on your scene. I have a GM session running in my Foundry VTT app, like always, and was testing this module as a player in Chrome. I can see the GM logged in the lower left hand corner and if I open a new connection to the game, I can see that the GM option has been grayed out, so the game recognizes that there is an active GM connection, so what could be the root of this error?

Regardless of lotting or converting the items to coin. The chat message shows up but I do not see the item removed from the NPC and added to my character sheet.

This is probably me, but when selecting a 0hp npc and running the macro,
(async () => { let actions = new InnocentiLoot.Loot(); await actions.Check(); })();

I get the following warning in the game
No token is targeted
and this in the console

ActionLoot.js:30 Uncaught (in promise) TypeError: this.targets is not iterable
    at ActionLoot.Check (ActionLoot.js:30)
    at eval (eval at callScriptMacroFunction (Macros.js:176), <anonymous>:5:86)
    at Macro.eval (eval at callScriptMacroFunction (Macros.js:176), <anonymous>:5:97)
    at Macro.callScriptMacroFunction [as callScriptFunction] (Macros.js:179)
    at Macro.renderMacro [as renderContent] (Macros.js:197)
    at Macro.executeMacro (Macros.js:221)
    at Hotbar._onClickMacro (foundry.js:20566)
    at HTMLLIElement.dispatch (jquery.min.js:2)
    at HTMLLIElement.v.handle (jquery.min.js:2)

Am I missing something?

Hello,

Can you add the translate french ?

Thank you
Innocenti Loot-Français.txt

Hello rinnocenti,

all icons of the coins do not show an image!

I found, the external link to https://5e.tools/img/items%2FGold%20(gp).jpg does not exisits. One of the correct link is https://5e.tools/img/items/PHB/Gold%20(gp).jpg.
I think it shoud be moved to a new location.