Comments (4)
Yes, this should be fixed. The behaviour when nil
is supplied should be the same as when no argument is supplied, and it's especially important to fix because it's a change from previous behaviour.
from ring-codec.
Thanks for the PR. Could you change the commit message to:
Fix nil argument regression in form-decode
Supplying nil as the encoding argument should have the same effect as
omitting the argument. This was the behavior in 1.0.1.
Fixes #32.
from ring-codec.
@weavejester would it be possible to cut a release with this fix? Or push a snapshot?
from ring-codec.
I released 1.2.0. Apologies for the delay.
from ring-codec.
Related Issues (18)
- Make the library nil-safe HOT 1
- url-encode should percent-encode + characters HOT 10
- Any chance at a release? HOT 3
- Support other query string param delimiters, ie: `;` HOT 2
- Extending FormEncodeable to nil HOT 5
- Nested map encoding HOT 4
- Support form-encoding namespaced keywords HOT 4
- form-decode : catch-all return nil is bad HOT 4
- Consider dropping commons-codec lib in favor of java.util.Base64 HOT 3
- ring.util.codec/FormEncodeable impl for nil HOT 4
- Documentation could explain the difference between url-encode and form-encode HOT 2
- Performance: short circuit form-decode-str HOT 7
- Performance: Lookup charset once instead of every call
- ring.util.codec/form-encode does not throw when passing nested map
- CLJX version HOT 2
- form-decode should accept an InputStream HOT 9
- NumberFormatException from ring.util.codec/percent-decode HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ring-codec.