Code Monkey home page Code Monkey logo

Comments (4)

weavejester avatar weavejester commented on August 24, 2024

Yes, this should be fixed. The behaviour when nil is supplied should be the same as when no argument is supplied, and it's especially important to fix because it's a change from previous behaviour.

from ring-codec.

weavejester avatar weavejester commented on August 24, 2024

Thanks for the PR. Could you change the commit message to:

Fix nil argument regression in form-decode

Supplying nil as the encoding argument should have the same effect as
omitting the argument. This was the behavior in 1.0.1.

Fixes #32.

from ring-codec.

danielcompton avatar danielcompton commented on August 24, 2024

@weavejester would it be possible to cut a release with this fix? Or push a snapshot?

from ring-codec.

weavejester avatar weavejester commented on August 24, 2024

I released 1.2.0. Apologies for the delay.

from ring-codec.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.