Comments (4)
I thought about adding a option map to form-encode
or to mock/request
to allow different key encoding schemes, but I don't think you'd save much code, a couple of lines at most. I think it's better to perform the transformation independently of the encoding function.
from ring-codec.
What about writing a function that transforms the keys into strings:
(defn kw->str [kw]
(str (namespace kw) "/" (name kw)))
(defn keys->strings [m]
(into (empty m) (map (juxt kw->str str)) m))
(defn mock-request [method uri params]
(ring.mock.request/request method uri (keys->strings params)))
from ring-codec.
Yep that's pretty much what we came up with (with some slight tweaks for unqualified keys). I could figure out what went wrong pretty quickly, but I wondered if this was something you wanted to look at fixing more generally. No problem if not, it's a pretty minor issue, easily worked around.
from ring-codec.
Cool, will close this for now then.
from ring-codec.
Related Issues (18)
- Make the library nil-safe HOT 1
- url-encode should percent-encode + characters HOT 10
- Any chance at a release? HOT 3
- Support other query string param delimiters, ie: `;` HOT 2
- Extending FormEncodeable to nil HOT 5
- Nested map encoding HOT 4
- form-decode : catch-all return nil is bad HOT 4
- Consider dropping commons-codec lib in favor of java.util.Base64 HOT 3
- ring.util.codec/FormEncodeable impl for nil HOT 4
- Passing nil to decoder decodes string to nil HOT 4
- Documentation could explain the difference between url-encode and form-encode HOT 2
- Performance: short circuit form-decode-str HOT 7
- Performance: Lookup charset once instead of every call
- ring.util.codec/form-encode does not throw when passing nested map
- CLJX version HOT 2
- form-decode should accept an InputStream HOT 9
- NumberFormatException from ring.util.codec/percent-decode HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ring-codec.