rillig / pkglint Goto Github PK

Hi.
'pkglint -e' no LICENSE error. in today pkgsrc-wip package:

• py-visionegg-demos
• py-visionegg-contrib

these package doesn't has LICENSE. buf pkglint -e no error.

% pkglint -e wip/py-visionegg-demos
ERROR: py-visionegg-demos/../../wip/py-visionegg/buildlink3.mk:18: Cannot read "py-visionegg-demos/../../mk/opengl.buildlink3.mk".
1 error and 0 warnings found.

% pkglint -e wip/py-visionegg-contrib 
ERROR: py-visionegg-contrib/../../wip/py-visionegg/buildlink3.mk:18: Cannot read "py-visionegg-contrib/../../mk/opengl.buildlink3.mk".
1 error and 0 warnings found.

Hey, this is of course for the lint project, not specifically pkglint. Didn't know where else to ask.

I would love to be able to lint more modern C projects with lint.

• C17 support
• C2x AKA C23 support
• FreeBSD entries in pkgsrc, pkgin, pkg
• OpenBSD, Hardened BSD, DragonflyBSD, MirOS ports
• macOS entry in Homebrew
• Windows entry in Chocolatey
• Haiku, Illumos, Plan 9 ports

(I like for my C projects to build incredibly portably.)

As a workaround, I am applying some C++ linters, which usually support C code as well. This includes compiler warnings, cppcheck, and cpplint.

Describe the bug

When I try to install pkglint, I get an error about a dependency missing. I think the dependency may have been accidentally omitted in the go.mod file.

To Reproduce
Steps to reproduce the behavior:

1. Run go install github.com/rillig/pkglint/cmd/pkglint@latest on a fresh environment, such as a Docker container with Go and no third party Go libraries preinstalled.

$ go install github.com/rillig/pkglint/cmd/pkglint@latest

go: downloading github.com/rillig/pkglint v21.1.2+incompatible
go: finding module for package netbsd.org/pkglint
../../../../pkg/mod/github.com/rillig/[email protected]+incompatible/cmd/pkglint/main.go:4:2: cannot find module providing package netbsd.org/pkglint: unrecognized import path "netbsd.org/pkglint": reading https://netbsd.org/pkglint?go-get=1: 404 Not Found

I also tried go install github.com/rillig/pkglint/...@latest, with similar results.

In fact, I also cloned the project into ${GOPATH}/src/github.com/rillig/pkglint and tried the conventional build command go install ./..., but that one is having trouble as well.

$ go install ./...
go: downloading golang.org/x/crypto v0.6.0
# netbsd.org/pkglint/licenses
licenses/licenses.go:22:12: undefined: liyyNewParser
licenses/licenses.go:72:39: undefined: liyySymType
licenses/licenses.go:79:10: undefined: ltOPEN
licenses/licenses.go:81:10: undefined: ltCLOSE
licenses/licenses.go:87:10: undefined: ltAND
licenses/licenses.go:89:10: undefined: ltOR
licenses/licenses.go:94:10: undefined: ltNAME

Expected behavior

Conventional go install ... commands for building and placing the pkglint binary into ${GOPATH}/go/bin should succeed on fresh Go environments.

I'd like to run pkglint in an automated environment where any warnings are flagged up. Currently pkglint only exits with an error status when errors are found.

I suggest adding a -Werror option that makes any enabled warnings fatal.

Describe the bug

While looking at pkglint output for lang/rust, I find:

WARN: Makefile:388: The pattern "riscv64" cannot match any of { aarch64 aarch64eb alpha amd64 arc arm arm26 arm32 cobalt coldfire convex dreamcast earm earmeb earmhf earmhfeb earmv4 earmv4eb earmv5 earmv5eb earmv6 earmv6eb earmv6hf earmv6hfeb earmv7 earmv7eb earmv7hf earmv7hfeb evbarm hpcmips hpcsh hppa hppa64 i386 i586 i686 ia64 m68000 m68k m88k mips mips64 mips64eb mips64el mipseb mipsel mipsn32 mlrisc ns32k pc532 pmax powerpc powerpc64 rs6000 s390 sh3eb sh3el sparc sparc64 vax x86_64 } for the hardware architecture part of MACHINE_PLATFORM.

To Reproduce
Steps to reproduce the behavior:

1. Run pkglint on package lang/rust

Expected behavior
The riscv64 (and riscv32?) target(s) ought to be recognized.