ricochet-exchange / rex-bank Goto Github PK

This issue involves setting up contract gas sizer. This is part of hardhat so depends on #24, look here: https://www.npmjs.com/package/hardhat-gas-reporter

There isn't currently a simple way to track how much was loaned out. This issue involves tracking these aggregate statistics somewhere in the contract and creating a getTotalDebtOwned()

Im not sure why I use msg.sender here but it makes it so that polygonscan UI doesn't let you read your amounts. I think I might have done this for privacy reasons. Its probably unnecessary

There needs to be a way to delegate liquidation management to keepers. Project teams are fine providing liquidity but do not want to be responsible for managing liquidations. There needs to be an allow list for adding keepers and allowing them to call liquidate.

This task involves converting the project to a Hardhat project, including moving over the tests. Probably dependant on #23

• Right now we track a reserve amount (reserve.debtBalance) which requires all deposits to call reserveDeposit()
• This issue is about replacing the internal reserve amount with calls to the balanceOf method

• This accounting method leads to tokens transferred or anything else will be locked and unaccounted for in the contract

• The above statement means anything not accounted for
• transferred tokens, will NOT be withdrawable, because they're not properly accounted for in the contract
• This is a pretty bad error in the contract since it can result in loss of funds
• • If tokens are ERC20 transferred into the contract, then they become locked forever
• Need to support streaming in the USDCx into the bank contract
• Need to get the debtBalance using the balanceOf method instead of tracking it in a variable within the contract, which is very prone to error
• A good fix is to make a method to get the current debt available, call it debtBalance()
• Sample debtBalance method:

fuction debtBalance() public view returns (uint256 balance) {
  return this.debtToken.balanceOf(address(this));
}

• This is based on the premise that any tokens in the contract can be borrowed, which is true
• Implement this as a method rather than putting this.debtToken.balanceOf(address(this)) all over the codebase
• Given the above implementation of debtBalance(), all the references to reserve.debtBalance will be replaced with debtBalance()

Use the "mainnet forking" strategy for testing to make it easier to use the Tellor oracle and Sushiswap LPs.

Go through and upgrade the contracts to version 0.8.0