rickypc / puppeteer-page-pool Goto Github PK

If an error is thrown in the function you pass to .process(), it get's swallowed and disappears.

I was pretty confused at what was going on before I realized this!

If pagePool.process encounter's an error calling fn, it should propagate the error (i.e. re-throw it) so it can be handled higher up the call stack.

Thanks for the neat package btw :)

I'm looking to add TS support to this. I've started a branch but it still needs some work. Would love any PRs from anyone that would like to help!

https://github.com/Joebayld/puppeteer-page-pool/tree/added-types

Hi @rickypc, and thank you so much for developing this! This is just what we need to generate PDFs, but unfortunately we’re unlikely to be able to use it under the AGPL license.

Would you be able to consider relicensing this under a more permissive license, such as MIT?

Many thanks again!