ricardojmendez / grails-encryption Goto Github PK

Expected Behaviour

... what should happen
No compile errors, run-app works as expected

.. what happens instead
| Error 2016-11-29 11:39:03,492 [Thread-11] ERROR compiler.GrailsProjectWatcher - Compilation Error: startup failed:
C:\git\cin\app\target\work\plugins\crypto-2.0\src\groovy\cr\co\arquetipos\password\PasswordTools.groovy: 7: unable to resolve class org.codehaus.groovy.grails.commons.ConfigurationHolder
@ line 7, column 1.
import org.codehaus.groovy.grails.commons.ConfigurationHolder as CH
^

1 error

Environment Information

Operating System: Microsoft Windows [Version 6.1.7601]
Grails Version: Grails version: 2.5.5
JDK Version:
java version "1.7.0_80"
Java(TM) SE Runtime Environment (build 1.7.0_80-b15)
Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode)
Container Version (If Applicable): n/a

Steps to Reproduce

TODO
Install Grails 2.5.5

TODO
Add groovy-all-2.4.4.pom next to groovy-all-2.5.5.pom

TODO
in grails-2.5.5\lib\org.codehaus.groovy\groovy-all\jars,
Add groovy-all-2.4.4.jar beside groovy-all-2.4.5.jar
Add groovy-all-2.4.4-javadoc.jar beside groovy-all-2.4.5-javadoc.jar
Add groovy-all-2.4.4-sources.jar beside groovy-all-2.4.5-sources.jar

TODO, in BuildConfig.groovy
Add to BuildConfig.groovy (either or both)
compile ':crypto:2.0' /* OpenPGP Support, including PGP Signatures /
compile ':mail:1.0.7' / Send Mail support for a running grails application */

Proposed fix (tested by modifying the plugin source in target\work)

Attempted fix to plugin source file in package cr.co.arquetipos.password
Class named PasswordTools.groovy of plugin crypto 2.0 ( OpenPGP support via BouncyCastle library )
Change line 7, causing "unable to resolve" error
From:
import org.codehaus.groovy.grails.commons.ConfigurationHolder as CH
To:
import grails.util.Holders as CH (from release notes for grails 2.5.5 )

See attached crypto-2.0.zip
crypto-2.0.zip

An exception is thrown when I try to run the application:

unable to resolve class org.codehaus.groovy.grails.commons.ConfigurationHolder

and I think this is for the changes done on Grails 2.0.

I will try to create a pull request if I made some time, but I wanted to create this issue because maybe I was missing something...

Thanks!

A patch was accepted from me a year ago, but the updates still have not been published to the Grails plugin repository. It'd be great if it were rolled out so the greater Grails community could start making use of it.

$ grails -plain-output plugin-info crypto

--------------------------------------------------------------------------
Information about Grails plugin
--------------------------------------------------------------------------
Name: crypto    | Latest release: 2.0
--------------------------------------------------------------------------
Encryption plugin for Grails
--------------------------------------------------------------------------
Author: Ricardo J. Mendez and Robert Fischer
--------------------------------------------------------------------------
Author's e-mail: [email protected]
--------------------------------------------------------------------------

Masks encryption and decryption functions, currently integrated with Bouncy
Castle. This version provides classes for PGP and Blowfish, as well as a
tool for both generating random passwords and salting / verifying salted
passwords.



Dependency Definition
--------------------------------------------------------------------------
    :crypto:2.0