Comments (5)
It only infinite loops if a non-zero error is always returned (never nil
). That's intentional. You can limit the looping with the strategy.Limit
, otherwise it'll keep retrying until it's successful, by design.
from retry.
yes, I agree, and for our internal transport client I wrote something like this:
if len(cfg.RetryStrategies) == 0 {
result.retryStrategies = []strategy.Strategy{
strategy.Limit(0),
}
} else {
result.retryStrategies = cfg.RetryStrategies
}
So, what you think if I modify shouldAttempt
to handle this case more cleaner?
from retry.
Oh, I see. You were passing strategy.Limit(0)
and expecting something different?
Not sure how this can be clearer.
from retry.
strategy.Limit(0)
run expected bad request one time (otherwise retry
moves our tests to infinite loops).
from retry.
strategy.Limit(0)
run expected bad request one time (otherwiseretry
moves our tests to infinite loops).
That doesn't make sense, though. A "retry" library shouldn't only perform an action once by default. If anything, the strategy.Limit
function should maybe document that the limit should be greater than 0
for the function to actually perform a limitation.
from retry.
Related Issues (4)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from retry.