@ronaldtse I have no write permissions for this repository. Could you fix it? Thanks.

In _compose_indices, if the objects variable contains an ORDER statement this would raise an error in MySQL 5.7+, e.g. when a controller wants to serve an index request with sorting options.

This is because in MySQL 5.7+, SELECT DISTINCT is not allowed to ORDER based on columns not included by the SELECT statement. Since we use .pluck so that Rails does not build the Ruby model object for efficiency reasons, as we only need the ids here, only the id column is part of the SELECT statement and keeping DISTINCT means we can not ask for a sort based on other columns. By removing DISTINCT, and filtering duplicates on the Ruby side using .uniq instead, we can still sort by non-id columns and still use .pluck so that Rails won't waste time trying to build the Ruby model objects.

format

README needs to be in asciidoc format.

content

The installation step is similar to inherited_resources.
Need usage instructions.
E.g.
Set up serializers (optional) config/initializers/synced_resources.rb

SyncedResources.base_time = MyApp.git_commit_time

# This may be more useful in RSpec...
SyncedResources.sync_string_encoder = lambda { |id_to_synced_at_map|
  MyApp.encode_sync_str(id_to_synced_at_map)
}

SyncedResources.sync_string_decoder = lambda { |encoded_map, base_time|
  MyApp.decode_sync_str(
    encoded_map,
    base_time,
  )
}

Then in e.g. app/controllers/foo_controller.rb,

class FooController < ApplicationController
  synced_resources
  # ...
end

or

class FooController < SyncedResources::Base
  # ...
end

Since SyncedResources inherit from inherited_resources, its options are also available for tweaking.

Right now we have a full-blown Rails application in spec/dummy, which adds some maintenance burden, like many configuration options which tend to change as Rails evolves. Also we want to test this gem against multiple Rails version, which makes things even more complicated.

Let's build this dummy application with Combustion, which requires us to write only necessary parts, and even disable unused Rails parts as needed.

Right now we clear database with explicit TRUNCATE statement which won't work with some database engines, e.g. with SQLite. Let's switch to a Database Cleaner gem.

Or drop support, but from #1 I conclude that it's still required.

e.g. ActionController.hide_action is no longer available.

@ronaldtse ?

There are four examples which do not pass. The result is consistent among Rails versions (at least ones which I was able to run so far, that is 4.1, 4.2, and 5.0). Failures happen every time I run these tests. See this build, for instance.

According to #15 (comment), they aren't normal. They reason they fail for isn't investigated yet.