When installing on a VM which does not meet the minimum memory specs. for a HANA install, you can specify parameter:

--hdbinst_server_ignore=check_min_mem

It would be useful to be able to provide additional parameters like this as part of the host configuration file.
e.g. hdbinst_additional_params=

task: sap-mount-media.yml

• file:
  name: "{{ installroot }}"
  state: directory
  owner: root
  group: root

This tasks fails because the installroot is already NFS mounted

Might be separate project

this role needs to be reorganized to be more granular, such as registration, disk-setup etc. in separate roles instead of this single one
A lot might be replaced by system rules should use the newly introduced system roles instead of this suboptimal scripting,

https://admin.fedoraproject.org/pkgdb/package/rpms/unar/

Greetings
Klaas

Documentate a easy way for a deployment of an automatical Example Deployment.
f.e. using Terraform:
export AWS_ID AWS_KEY
terraform apply
ansible-playbook ....
terraform destroy
finished

Base Host setup

There is a lot of commented lines in this role. Comements should be moved from main.yml into the role README.md

Task: Enable Debugging
Why do we set debug to 3 on one, empty task? I do not see debug msg's anywhere else in base-host-setup

Include statements
Both optional
We call both system-registration-part1.yml & RH7 | RH6 based on conditional check_repos and system release
What about the RHEL 7.2 task being commented out?
Can we enforce a desired state here?
Can we set repos based on release?
What about task 'reset all repositories'? Shouldn't this be all that the system is configured for?

Lots of conditional logic. Things like 'when check_repos'.. doesn't need to be setup.
We should confirm repositories are configured and if not, pass an option to run a config for RHSM

Currently there is a lot of hardcoding of paths in deployment > tasks > deployment.yml, for example:

- name: create usr sap directory
  file:
    path: "/usr/sap/{{ item.value.hana_sid|upper }}"
    state: directory
  with_dict: "{{ instances }}"

I count that path 3 times in that file, so we could do something like:

var: 
  sap_usr_path: /usr/sap/{{ item.value.hana_sid|upper }}

This would improve legibility and reduce the number of manual paths, so it becomes easier to modify in the future if necessary. This is generally a good practice from a role reuse perspective.

Currently it looks like there are two locations for usage -- the general README.md and under docs/hana-host.txt

Generally when publishing playbooks with nested roles, it's good to provide a high level document as README.md and then provide a README for each respective role that explains it's purpose.

We also don't point users from the current README to docs/hana-host.txt, so at the very least if not changing the structure the items under docs/ should be updated.

These task should be setup compliant to redhat system roles

Need three roles:
Self-Configured integration
Satellite 6 Integration
subscription-manager integratation

Checks:
Check if packages available from needed repositorys.

For Demo Scenario:
Use RedHat Login as variable
execute following commands (example):
subscription-manager clean
subscription-manager remove --all
subscription-manager register
rm -rf /etc/yum.repos.d/*
rm -fr /var/cache/yum/*
yum clean all

subscription-manager list --available --all

subscription-manager attach --pool=xxx
subscription-manager release --set=7.2
subscription-manager repos --disable=rhel-7-server-rpms
subscription-manager repos --enable=rhel-7-server-eus-rpms

Deltarpm is necessary for the following rpm installation ?!?!

yum install -y deltarpm

All tasks and changes need to be documented better, so that they refelect the usage of SAP Notes used

check if package firewalld is installed
hana-host/tasks/RedHat7/service-configuration.yml:- name: disable firewalld
hana-host/tasks/RedHat7/service-configuration.yml: service: name=firewalld state=stopped enabled=no
preconfigure/tasks/RedHat7/service-configuration.yml:- name: disable firewalld
preconfigure/tasks/RedHat7/service-configuration.yml: service: name=firewalld state=stopped enabled=no