rhelli / newsweek-clone Goto Github PK
View Code? Open in Web Editor NEWA clone of the NewsWeek website build using the Bootstrap CSS framework
A clone of the NewsWeek website build using the Bootstrap CSS framework
Things might help on code reviews:
Some code reviewers are kinda of picky with things. (The HTML indentation might be picked up by some code reviewers)
Bootstrap has a hierarchy (First of all, container. After that, nest as many rows as you want. Inside the rows, you can have as many columns as you may want).
You might face a bootstrap expert on your code review and that would be bad.
The code looks great until line thirty (30), but then the hightlight breaks after that. Line 33 has a different color.
Using too much custom CSS for organizing the page and leaving bootstrap aside (kinda defeats the purpose of the project).
It's possible to use bootstrap cards on some articles.
line 20: columns nested in rows
line 22, 26 and 28: same level columns, but the three adds to 18 (not 12)
line 102: row inside container
line 103: great use of order for the elements
Take a look on nesting in container. Position sticky part is missing you can achieve.
formatting on html should be improve.
. Good project
. Refactor code before pushing
.Issue on line 21, index.html (branch headerNav-branch): HTML elements that are of the classes col-, col-sm-, col-md-, col-lg- or col-xl-* must be direct children of a parent element that is of the class "row".
Example of correct use of bootstrap's grid of twelve columns sistem:
<div class="row"> <!-- "row" must have "col-*-*" as children! -->
<div class="col-6">Column A</div> <!-- "col-*-*" must have row as parent! -->
<div class="col-6">Column B</div>
</div>
. It looks like that have misunderstood the role of the class "flex-row" of bootstrap. "flex-row" does not make a div
element to become a logical row of bootstrap. It's simply a shorthand for adding this rule to the styling of the element: "flex-flow: row".
.look at the search input not working(onclick)
.start with small screens scaling up to big screens
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.