Code Monkey home page Code Monkey logo

newsweek-clone's Introduction

Hi, I'm Rory 🤙🏽

My Languages And Tools:

                                         

newsweek-clone's People

Contributors

rhelli avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

newsweek-clone's Issues

Peer-to-peer Code Review

  • (Amazed at how the styling is similar to the original website)
  • Applying container inside row looks strange. Rows should be inside containers.
  • There are quotes where there are not supposed to be.

Things might help on code reviews:

  • Some code reviewers are kinda of picky with things. (The HTML indentation might be picked up by some code reviewers)

  • Bootstrap has a hierarchy (First of all, container. After that, nest as many rows as you want. Inside the rows, you can have as many columns as you may want).

  • You might face a bootstrap expert on your code review and that would be bad.

  • The code looks great until line thirty (30), but then the hightlight breaks after that. Line 33 has a different color.

  • Using too much custom CSS for organizing the page and leaving bootstrap aside (kinda defeats the purpose of the project).

  • It's possible to use bootstrap cards on some articles.

peer to peer Review 5/12/2019

  •  line 20: columns nested in rows
    
  •  line 22, 26 and 28: same level columns, but the three adds to 18 (not 12)
    
  •  line 102: row inside container
    
  •  line 103: great use of order for the elements
    
  •  Take a look on nesting in container. Position sticky part is missing you can achieve.
    
  •  formatting on html should be improve.
    

peer to peer review [25th nov 2019]

. Good project
. Refactor code before pushing
.Issue on line 21, index.html (branch headerNav-branch): HTML elements that are of the classes col-, col-sm-, col-md-, col-lg- or col-xl-* must be direct children of a parent element that is of the class "row".

Example of correct use of bootstrap's grid of twelve columns sistem:

<div class="row"> <!-- "row" must have "col-*-*" as children! -->
<div class="col-6">Column A</div> <!-- "col-*-*" must have row as parent! -->
<div class="col-6">Column B</div>
</div>

. It looks like that have misunderstood the role of the class "flex-row" of bootstrap. "flex-row" does not make a div element to become a logical row of bootstrap. It's simply a shorthand for adding this rule to the styling of the element: "flex-flow: row".
.look at the search input not working(onclick)
.start with small screens scaling up to big screens

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.