tdd_0826_homework's People
tdd_0826_homework's Issues
review completed, good job!
完成地很漂亮,從命名到設計都很用心。請見各 commit 的 review comments。
幾點建議:
- 測試案例重構的時間點可以再早一點
List<List<List<PotterBook>>>
可能要考慮職責上的抽象,例如以Suite
來代表List<PotterBook>
,並將TotalPrice
封進去Suite
裡面
提供我的 sample solution 給你參考:https://github.com/hatelove/PotterShoppingCart2017/blob/master/PotterShoppingCartTests/Cart.cs
我有點偷吃步,只針對 5+3 pair 轉換成 4+4。如果未來需求有變化,可能就會錯了。你的作法(找出組合)比較穩定與完整。
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.