revelrylabs / harmonium Goto Github PK
View Code? Open in Web Editor NEWAn opinionated React component framework for teams that move fast.
Home Page: https://harmonium.revelry.co
License: MIT License
An opinionated React component framework for teams that move fast.
Home Page: https://harmonium.revelry.co
License: MIT License
stateless and stateful versions
https://foundation.zurb.com/sites/docs/badge.html
<Badge>
[things]
</Badge>
Not sure what's going on, but I always have to restart.
I’m trying to add some props to the Button component, but doesn’t seem like they are rendered
import Button from 'revelry-components/src/Button';
class MyExample extends React.Component {
render() {
return (
<Button alert value="cancel" type="submit" name="action">Cancel</Button>
);
}
}
Renders as:
<button class="RevButton button alert" data-reactid="7">Cancel</button>
Expected:
<button class="RevButton button alert" value="cancel" type="submit" name="action" data-reactid="7">Cancel</button>
http://foundation.zurb.com/sites/docs/orbit.html
Roll your own JS into the component. Read here to learn how to make CSS animations happen properly in React: https://facebook.github.io/react/docs/animation.html
Add button trigger for modal example so a user can see how it works and looks/feels.
Details guidelines and tips for the following:
(Tests should use mocha/chai/enzyme.)
A common task we need to do in applications is share a page on social media. We should build a reusable component for share links.
Implementation notes:
We should use the link method supported by most network, not any javascript based share widgets or SDKs. These add a ton of page weight and clash with everything else. Links are simple, easy, and flexible and are a cornerstone of the web. Stop making it complicated. No really, stop.
This repo does a good job of documenting the common options for different networks, but some of them may have more options not listed there: https://github.com/bradvin/social-share-urls
Don't worry about icons or images or button look vs link look-- we're going to use the children
prop to define the contents of the share link, remember?
Component Vars Audit
$[component]-[css-property]-[variant]-[state]
!default
vars listed at the top of the component stylesheet!default
s and comment out using //
. This way, uncommenting vars in the settings file will easily overwrite the !default
vars on the component stylesheethttp://foundation.zurb.com/sites/docs/pagination.html#
As a user...
As a developer...
Displays basically all the visual components in one spot. Easy way for designers to add a style guide to the project.
I'd like to use a Brand
component for adding the logo to a site, along with screenreader text and link to homepage or root of app.
I'd like to write it somewhat like this:
<Brand href="root or landing page" img="logo.jpg" title="screen reader title" />
Where the generated markup looks kind of like this:
<a href="props href" className="rev-Brand">
<img src="magic-image-path-to-logo-from-props"/>
<span className="ShowForSR">props Title for Screen Readers</span>
</a>
https://foundation.zurb.com/sites/docs/label.html
<Label>
[children]
</Label>
Cards come up frequently in applications. I think we should add a card component (with some common variations) to our framwork. Material Design has a good "system" of variations for cards, and they've thought about handling cards with images / video, cards with action buttons, responsive layout, etc. I would suggest we use their "system" / "wireframes", but implement in our toolkit, using foundation styles which go with our other styles (e.g. cards probably have the same corner and border as callouts?).
Link: https://material.google.com/components/cards.html#cards-usage
Acceptance Criteria:
this.props.children
http://foundation.zurb.com/sites/docs/flex-grid.html
import {Row, Col} from './flexGrid'
the same way I import {Row, Col} from './grid'
Right now, the docs site is pretty barebones and doesn't really show off the styles of the framework.
Would like to build a site that has:
https://foundation.zurb.com/sites/docs/forms.html
<HelpText>[children]</HelpText>
The pagination component handles making elements of navigation, but how do you have it create proper links for your pagination scheme?
Nick was looking at it and didn't see the option. Either it is there and not properly documented, or it isn't there and should be.
The idea: a button / link / switch / etc for actions that are dangerous and need confirmation. When given an event handler (i.e. onClick / onChange / onSubmit), it wraps it such that it first displays a designed confirmation message and a confirmation button / link /switch / etc. Only upon hitting the confirmation does the original event handler actually run.
We frequently get requests that the error message should go away when the input value is changed. Let's build this in so that we can stop making per-project code that almost always sucks.
From our conversation here: https://github.com/revelrylabs/dcm/issues/245 We need to create two types of table components for Rev Core.
A table component that actually uses the <table>
tags
A table component that mimics a table, but uses Rows and Cols (or listed items). A reference for this type of table is already built out for DCM.
Also, make sure to follow the instructions for the mobile table view from the DCM reference above.
Right now, all the components are in a flat directory and so they just show up as a alphabetical list on the cli and in editors. It would be better if it were organized into logical groups (e.g. grid, forms, nav).
src
build directly into the root of lib
(so we don't break projects using the old scheme) as well as their real place in the structureand add the appropriate build pipeline for the docs site.
we don't need to build the stylesheet for distribution. i think it's fine to expect people to include the right component-specific sass files from node_modules/revelry_core_node/scss
or whatever.
scss/
directory is created, and these files are also built into docs site styles.Want to start building our roadmap for the back half of this year, work out what we're doing and not doing.
Thoughts in no particular order
revelry_core_node
is a particularly bad name because it isn't really for node, and it isn't just for Revelry. Even the package name revelry-components
is bad, because you can use this outside of our toolkit. We should name this thing after what it does and why you would use it.Open to any other ideas. Let's get it all on the board and decide how and where to start.
I'd like to be able to update the example markup. I want to add descriptions and reasons behind why we made certain decisions, as well as provide clarity into how components behave inside other components vs. on their own.
Currently, I can only add an h2 title for a component example.
As a user of the internets, I would like to see a well designed, informative notification if the site or application I am visiting is not supported because of my old-ass browser.
Unless specifically required for a really really (REALLY) good reason, 'out of date browser' notification should show for lt-ie9.
Something along these lines:
https://github.com/ded/bowser
AC:
http://foundation.zurb.com/sites/docs/close-button.html
<CloseButton icon="optional-icon-name">
<span>Optional content inside close button</span>
</CloseButton>
We're using ExpandingColStateContainer when it should probably be ExpandingCol.Stateful to match other things.
https://foundation.zurb.com/sites/docs/media-object.html
<MediaObject>
<MediaObjectSection>
[things]
</MediaObjectSection>
<MediaObjectSection>
[more things]
</MediaObjectSection>
</MediaObject>
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.