Code Monkey home page Code Monkey logo

Comments (4)

jorisdejong avatar jorisdejong commented on August 30, 2024

SetFloatParam is being called continuously while you hold the button down, which means you're constantly deleting the shader and creating a new one. Accessing it on ProcessOpenGL while this is happening is not safe.

For ParamEvents, ideally you want to implement OnClick and OnRelease functions that get called once, by checking against the previous state. To be completely safe, you'll then want to use these functions to set a variable that gets checked on the render call.

from ffgl.

perrelet avatar perrelet commented on August 30, 2024

Thanks for the reply J,
Setting up onX event-watchers has been my solution, and works fine.
However FYI - when I was bug checking this issue I found that the critical crash occurs the instant a gl call is made from within SetFloatParameter, not when ProcessOpenGL is fired.
i.e in the above code snippet newVertexShader is not a variable used elsewhere (such as ProcessOpenGL) - rather, it is a standalone test call that brings the entire house of cards tumbling down! This certainly wasn't the case in FFGL 1.5 so I do indeed have to wonder where the instability is...

from ffgl.

jorisdejong avatar jorisdejong commented on August 30, 2024

This repo is still FFGL1.5. It just has been cleaned up, and now has a minor bug fix for displaying parameters on 64 bit. Nothing has changed for making OpenGL calls.

I assume you are experiencing these crashes in Resolume 6?

from ffgl.

jorisdejong avatar jorisdejong commented on August 30, 2024

We had some internal discussion about this, and changing the OpenGL state anywhere else than the render thread is not a good idea.

from ffgl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.