Tag created from wrong revision in svn about gradle-release HOT 9 CLOSED

What stage are you updating gradle.properties? there's a preTagCommit task which commits changes just before it creates a tag. And there's a commitNewVersion which commits the final version change after the tag is created. The commitNewVersion should only commit the properties file.

from gradle-release.

Hi,

I believe I am experiencing a similar issue. The gradle.properties file that gets tagged has the SNAPSHOT version. See svn logs below:

Before the release task is run:
gradle.properties:
version=4.15.4-SNAPSHOT

r56154
[Gradle Release Plugin] - pre tag commit:  '4.15.5'.
---------------------
gradle.properties:
version=4.15.5

r56155
[Gradle Release Plugin] - creating tag:  '4.15.5'.
---------------------
gradle.properties:
version=4.15.4-SNAPSHOT


r56156
[Gradle Release Plugin] - new version commit:  '4.15.5-SNAPSHOT'.
---------------------
gradle.properties:
version=4.15.5-SNAPSHOT

I would have expected the version value in the tagged gradle.properties to be 4.15.5.

Have I missed anything?

from gradle-release.

Hmm. It should be working fine. Did you update the version number during the process? The plugin asks you to enter the current version before it creates the tag, which looks like that's what happened here, otherwise the pre-tag-commit and tag should have the version as 4.15.4. Later in the process it asks you for the next version which is what should be in the new-version-commit

from gradle-release.

The name of the tag in svn is correct (4.15.4). It is just the version value in the gradle.properties file. I will give it a few more tries. Cheers.

from gradle-release.

Ok. Definitely let me know if you're still having the issue.

There was an existing bug where it would do this if you updated the version number during the process - I thought I fixed it, but it could be on master and not officially released yet.

from gradle-release.

Hey Eric,
Happens every time for me. Even when I specify the -Pgradle.release.useAutomaticVersion=true
Are you able to replicate it? would be great if you could put the fix up. Cheers.

from gradle-release.

Hi Eric,

I am using the 1.2 version of gradle-release plugin, should I build a version from the master to use?

Do you receive emails when comments are added directly to github or only when I reply directly from my email client?

I ran the plugin a few more times and the same issue (#48) happens every time for me. Even when I specify the -Pgradle.release.useAutomaticVersion=true

Are you able to replicate it? would be great if you could put the fix up. Cheers.

from gradle-release.

Sorry, I do get them but they get archived and hidden a way in a folder I don't often check.

You could try building from source, I haven't had time to reproduce the issue but I have in the past, and I'm pretty sure I fixed it in master.

Sorry, again. I really don't have a lot of time for this project, which is why I asked the gradle community to see if someone could take it over.

from gradle-release.

This is fixed with d9ffcb3 and will be released in 1.3

from gradle-release.