Somehow ./gradlew release inserted a leading space to

Is that extra space from here?: <div class

Leading space inserted for title of pre tag commit about gradle-release HOT 3 OPEN

tueda commented on August 22, 2024

Leading space inserted for title of pre tag commit

from gradle-release.

Comments (3)

peetkes commented on August 22, 2024

we also ran into this while we setup workflow rules on skipping commits which started with '[Gradle Release Plugin]'. The pre tag commit slipped through because of the leading space.

from gradle-release.

pschyska commented on August 22, 2024

Is that extra space from here?:

gradle-release/src/main/groovy/net/researchgate/release/tasks/PreTagCommit.groovy

Line 26 in af4bf46

message = "${extension.preCommitText.get()} ${message}"

Our preCommitText is empty, and we get the leading space in the commit message as well.

from gradle-release.

peetkes commented on August 22, 2024

That seems a logic explanation. Would it make sense to check if preCommitText if empty before prepending it to the message? Maybe the preCommitText should contain [Gradle Release Plugin] and change the other ones like below:

    @Input
    final Property<String> preCommitText = project.objects.property(String.class).convention('[Gradle Release Plugin] -')

    @Input
    final Property<String> preTagCommitMessage = project.objects.property(String.class).convention('pre tag commit: ')

    @Input
    final Property<String> tagCommitMessage = project.objects.property(String.class).convention('creating tag: ')

    @Input
    final Property<String> newVersionCommitMessage = project.objects.property(String.class).convention('new version commit: ')

from gradle-release.

Recommend Projects