rerdavies / pipedal Goto Github PK

Rename preset. Modify preset. Save preset.

Result:

Name reverts to original name.

Is your feature request related to a problem? Please describe.

Rebuilding pedalboards after a change causes a discontinuity in audio processing. If plugin instances were re-used, things like reverb tails would be continuous and uninterupted after a patch change, as long as the patches are structurally similar.

Describe the solution you'd like

When building pedalboards, reuse plugin instances from the previous pedalboard when IDs match. Eliminate the pop filter if structure is identical or substantially (?) similar. Re-used instances would preserve state across the patch change.

Requires the following changes:

• Recycling of matching plugins; garbage collection of plugins that don't get recycled.
• Conditional application of the pop filter when changing patches.
• Special handling of control changes when recycled plugins are activated in the audio loop.

Describe alternatives you've considered

Additional context

Describe the bug
I managed to install and operate the pipedal succesfully with my focusrite scarlett 2i2, komplete audio 2 and MOTU2 soundcards.
Howerever, when I tried to use an irigHD2 card, a UGM192 soundcard and a TC-helicon Guitar pro there was no sound outputed or seriously distorted noise was getting out of my speakers. All of these cards are fully recognized from the system and working properly with the pi4, when pipedal service is stoped.
Please advice.

I use the pi4 chromium browser with a mouse and keyboard attached directly to pi4b, albeit the wifi direct function works fine on my android phone.

Describe the bug
The dpkg is missing a dependency on the authbind package.

To Reproduce
Install on a clean system. systemd gives the following message:

Error: 'authbind' is not installed.

Describe the solution you'd like
Extend MIDI bindings dialog to include OpenSound. Add OpenSound processing to LV2 Main processing loop.

Describe alternatives you've considered

Additional context

Describe the bug

Not immediately clear that you have to select an audio device when first installing pipedal.

Expected behavior

Provide an onboarding sequence on first install that forces selection of an audio device, and offers an opportunity to configure wifi.

Error in log:

Failed to create secure directory (/home/pipedal_d/.config/pulse): No such file or directory

There are plugins that need the home directory as well.

Support MIDI program/bank select.

Support MIDI next/previous program.

Binaries have libstdc++6 version 11 dependencies. Downgrade to GCC 10.3 toolchain to allow installation on Raspberry Pi OS.

Provide VU and volume trim controls on input and output nodes. Also add a mute button on the output node (or implement the bypass button as a mute button, perhaps).

Suggested by user EE1977 in issue "soundcard not working properly [BUG] Description #79".

Portrait/landscape flips when controlling PiPedal from a phone are disruptive.

Add a setting to lock the display orientation to landscape (probably Auto/Portrait/Landscape in order to conform to UI convention).

Is your feature request related to a problem? Please describe.

Not currently able to use MIDI plugins.

Describe the solution you'd like

Provide routing of MIDI messages in the routing view.

Add a reliable pitch to midi converter plugin.

Describe alternatives you've considered

Additional context

For future release.

Either downgrade the gcc compiler to v10, or staticly link libstdc++6 library.

Mar 10 02:03:23 raspberrypi authbind[27885]: terminate called after throwing an instance of 'std::invalid_argument'
Mar 10 02:03:23 raspberrypi authbind[27885]: what(): Invalid uri.

To Reproduce
Plug in an audio adapter that has 1 input channel and 2 output channels.

Select the audio device.

Restart pipedal.

Result: service crashes on launch with "invalid channel" message.

Is your feature request related to a problem? Please describe.

A common use case for Guitar Multi-effects is to use a pedalboard to to bypass effects selectively. For example, Roland GT10 provides this mode as an optional way of using the pedalboard controlls. Each pedal is bound to the bypass control of effects in the chain.

In the current UI, you have to select the pedal, and then click on the bypass control.

For this use case, it would be more effective to allow toggling of the bypass for an effect with a single click.

Describe the solution you'd like

An alternate view of the pedalboard layout where clicking on an effect toggles the bypass switch for that effect.

Describe alternatives you've considered

Additional context

Control interface is crowded on landscape phone display, and controls have to pop up in a strip anyway in this format to provide adequate borders for manipulation.

Get rid of the route/control split on this display format only, and pop up a full-screen interface when editing controls.

As of now, I have pipedal connected to my local ethernet network and I get a constant error while trying to connect from my desktop computer. The web browser refuses to load the pipedal interface and returns "Error. Failed to connect server". Any suggestions? As I recall, the last time I tried to connect via ethernet was on version 1.0.19 and I had no problems.

On first load (and whenever there isn't a selection), the first plugin should be selected. Usability issue: we want the Load button to be enabled on first load.

An warning message about not being able to stop the jack service give during service stop/start/disable.

Expected behaviour:

Legacy code that should either be silenced or removed.

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
I wish there were more examples or a way to share presets between users. Setups for specific song for example.

Describe alternatives you've considered
I guess each user could create their own presets. :-/

Additional context
N/A

Add sponsorship button to readme.md.

Are there any particular IR (impulse response) loader plugins that are compatible with pipedal and allow the user to load custom IRs? If so I'd like some more info. As far as I managed to try some plugins, although the plugin panel appears, there is nowhere to see how a custom IR could be loaded. Thank you.

Fit and finish issues

• Save Plugin Preset default name doesn't take name of last selected plugin preset. Makes it easier to save a modified preset.
• Save json configuration files in pretty-printed format (easier for support)
• Toob Flanger LFO vu layout is incorrect when LFO is at max value. (bi-directional VU, color selection?)

Missing plugins still lead to problems.

• Display error in pedalboard.
• Display message in control view indicating which plugin is missing.
• Server-side audio should render without the plugin instead of stopping.

Chrome is still trying to auto-save the wi-fi password field.

Description:

• User selected a custom http port.
• Users installed a new version.
• Port selection reverted to default

Expected behavior:

• The port selection should be preserved.

Need to review code to see if the port number is already accessible in a settings file (I think it isn't).