Renovate-approve bot approves only once even if 2 reviewers are required. Does it take sometime to approve as 2nd reviewer ?

Hello,

I have been recently using both renovate and renovate-approve for many of my repos. I ran into an issue where my CODEOWNERS file was breaking. I reached out to GitHub support this was their response. This directly conflicts with the description of

"If you need to add this bot to your CODEOWNERS, you can identify it using app/renovate-approve."

with the Dismiss stale pull request approvals when new commits are pushed setting enabled on branch protection then the approve-bot doesn't re-approve on subsequent commits
what this means in the real world is if renovatebot creates 5 prs, 1 will get approved and merged, the others will auto rebase or merge commit, but then approve-bot doesn't approve it, so i've now got 4 prs I need to manually approve.
Hope that makes sense?

It would appear that this: https://github.com/renovatebot/renovate-approve-bot/blob/main/index.js#L61
isn't happening, for example:
DaftDoris/newsdesk#447 (comment)

The utilities adduser, addgroup and apk experienced some hiccups with the change to the amd64/node image. I have created a PR at #44 that resolves the error. See the PR for more details.

Pull requests which are created through our scripts using Github APIs are getting approved by renovate approve bot. Bot is not validating if the PR is generated by renovate or not.

Is this the known bug ?

I added the approver but it doesn't seem to actually approve.

How should I read the logs from dashboard?

Affected PR: gqty-dev/gqty#1180

I have few questions, as I am new to renovate. Kindly assist.

Can I use renovate-approve for Java, Python and Docker ?

I reason I have this question is because package.json is used in dockerfile

If available, Please provide the detailed documentation as to how to build the dockerfile and deploy in OCP. We have renovate already on OCP from other team, how to integrate approve bot to make it work with renovate ?

Which Renovate are you using? x the right box:

• Renovate Open Source CLI
• WhiteSource Renovate App
• Renovate Pro
• Other (please write below)

Which platform are you using? x the right box:

• GitHub.com
• GitHub Enterprise
• GitLab.com
• GitLab self-hosted
• Bitbucket Server
• Bitbucket Cloud
• Azure DevOps

What would you like to do?

I have the renovate-approve BOT enabled and I'm noticing that it's approving PRs even when the status checks (like our CI status check) is red. I wouldn't expect the BOT to approve PRs whose status checks are not green. Is there a way to configure this?

Hi! On our repo https://github.com/ecamp/ecamp3/pulls, renovate approve bot 1 works perfectly, but approve bot 2 has stopped doing anything about a week ago. I have tried removing it from the repository completely and re-installing it, but that didn't help so far. Any ideas what's wrong?

We would like to install renovate-approve-2 bot on our hosted instance. I am not finding the link to the source code.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Pending Approval

These branches will be created by Renovate only once you click their checkbox below.

• chore(deps): update actions/checkout action to v4
• chore(deps): update docker/build-push-action action to v5
• chore(deps): update docker/login-action action to v3
• chore(deps): update docker/metadata-action action to v5
• chore(deps): update docker/setup-buildx-action action to v3
• chore(deps): update docker/setup-qemu-action action to v3
• fix(deps): update dependency probot to v13
• 🔐 Create all pending approval PRs at once 🔐

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

• chore(deps): lock file maintenance

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update node.js to db4b1d9

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Here is my CODEOWNER file

/package.json @app/renovate-approve

where renovate-approve is the name of the github application. Am I doing it right?

I've hopefully done all the right things:

1. Added renovate approve bot with the right permissions to the repository
2. I don't have branch restrictions on who can push to the branch
3. The branch has automerge enabled and all statuses succeed

If the approve bot was working, would it immediately add a review or could that be delayed? Thats the only thing I'm not sure about because in the process of testing things some branches have been blocked by statuses or conflicts.

here is a public example branch that I ended up merging myself because no review came from renovate: woocommerce/woocommerce-admin#5045

Background:

The AMP Project has been using forking-renovate for a couple years now, and I'm in the midst of trying to up our game by enabling auto-review and auto-merge for upgrade PRs that pass other CI checks. However, I haven't been able to get things to work after multiple tries, and figured I'd check in here for help. Please feel free to move this issue if this is the wrong repo.

Details:

• Our repo is located at https://github.com/ampproject/amphtml
• Contributions are normally made via forks, so we installed https://github.com/apps/forking-renovate
• All upgrade PRs are at https://github.com/ampproject/amphtml/pulls/renovate-bot
• I installed https://github.com/apps/renovate-approve so PRs that pass CI are auto-merged
• Our renovate config is located at https://github.com/ampproject/amphtml/blob/main/.renovaterc.json
• I've set automerge and assignAutomerge as true for the config groups that we want auto-merged

Problems:

• renovate-approve has not been added as a reviewer / approver for any PR thus far
• If I manually review / approve a PR such that all PR statuses are green, the PR is still not being auto-merged

Questions:

• Is auto-merge supposed to work with forking-renovate?
• Are the steps listed above the correct steps? (Or did I misconfigure something?)
• Any other steps I should've taken?

Thanks in advance for the help!

If the user has configured to dismiss PR reviews when they're stale, then Renovate Approve's approval will be removed every time the branch is rebased/force pushed. Renovate Approve needs extra logic to detect this and add a new approval.

          ```suggestion

Renovate supports OCI HelmRepository sources (type: oci).
Renovate will extract the docker dependencies for the referenced HelmRelease resources.

I'd like to see something like this. Where we have two full sentences, and limit the use of `()`. The sentence should also say who does what.

Please check if my suggestion is accurate. 😉

_Originally posted by @HonkingGoose in https://github.com/renovatebot/renovate/pull/24197#discussion_r1313047488_
            

We enabled automerge on some sub-configuration (subset of devDependencies packages) in an attempt to reduce the noise in our PRs (and increase even more the value of Renovate!), but even with this type of PRs:

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

The renovate-approve bot approves the PRs, doubling the amount of emails/etc.

Since this bot's job is to only help automerges, it would be great if it was only approving PRs with:

🚦 Automerge: Enabled.

Thanks! 🙏

Hello,

is there any plan to convert this bot as a github actions workflow, so that it runs whenever a PR is opened, this is similar to what is happening here

i've started configuring replacements within a private project that has approval requirements. while the approval bots have been working well for dependency update PRs, i noticed that approvals were not added to replacement PRs.

is this an intentional limitation? if it is unexpected, what details could i provide that would be helpful?

Currently, there are two Renovate Approve apps available on GitHub:

• Renovate Approve
• Renovate Approve 2

We need to have third, how we can get "Renovate Approve 3" 😅

Best regards

First off, both renovate and renovate-approve are fantastic tools! Thank you!

I am looking to use renovate-approve-bot with a self-hosted renovate-bot deployment. Is there a simple way to configure renovate-approve to approve changes created by our renovate user (our user is a Github user)?

If I am understanding the code base, it appears that it the process.env.RENOVATE_BOT_USER variable is configurable to new usernames (though it looks like it pulls that from the deployment's environment).

Is it simply the case I will need to self-host the renovate-approve bot in a private app to configure that setting? If so, would you be able to provide some guidance on running it in a private app?

The renovate-approve-bot automatically approves Renovate's configuration migration PRs. I think we should let our users review the changes themselves instead of auto-approving.

Right now the configuration migration PRs makes some whitespace and ordering changes, so the PR probably needs to be fixed up by the user anyways.

To summarize: disable renovate-approve-bot approval for Renovate config PRs.

I would like to require 2 reviewers, but that would mean renovate-approve alone is not enough.

Is there a way to have 2 of these bots?

Since approximately yesterday at noon GMT, renovate-approve-bot 2 does not open any reviews on our repository https://github.com/ecamp/ecamp3 anymore. I already tried re-installing the bot, and renovate has opened a new PR since then, but approve-bot 2 seems to be on vacation. Do you have any insights on this?

Strangely, it first stopped working on ecamp/ecamp3#865 but still worked on ecamp/ecamp3#864 two hours later.

We have recently changed the renovate config in ecamp/ecamp3#854, maybe it's something to do with that. However, renovate itself works perfectly fine.