Use Hooks about genesia HOT 15 CLOSED

Mail.js is now rewritten using hooks, #24

from genesia.

My proposal in #29 , what do you think? @adeelibr @ccampean

from genesia.

@adeelibr Good advice! I consider to implement it on next PR, I can search more services like mailnesia

from genesia.

I am making a PR for this.
Change this file to Hooks only? https://github.com/Remeic/genesia/blob/master/src/Mail.js

Also should this be dumb functional component only https://github.com/Remeic/genesia/blob/master/src/App.js?

from genesia.

@adeelibr hello! Thanks for contributing, I think you can implement hooks only in mail.js

from genesia.

@ccampean I was about to make a PR when i saw this :D Thank you for the heads up :)

from genesia.

@adeelibr if you want, send the PR, so we compare them, I also wrote my own version with hooks. we can learn something more

from genesia.

I like the fact that the component is cleaner now.

from genesia.

@Remeic looks good to me.

from genesia.

@ccampean i see your PR, i prefer don't link suffix with useState, because is immutable string.
Can I know why you chose to use useState? maybe something escapes me.

from genesia.

I missed that variable. It should be outside of state's component.

from genesia.

@ccampean No problem, I'm here to learn. Thanks again!

from genesia.

I think it should inside the state component, because getComposedMail is used as a function in the state component that takes in 2 params, assuming there can be multiple suffexes for different components, I think it's better if it stays inside the component.

from genesia.

@adeelibr so you advice to move suffix in the state of component, in case there are multiple suffixes, right?

from genesia.

Yes, & if you want more control over the suffixes just pass a suffix prop down your component, and have defaultProp for suffix = somerandomvalue in case no one passes the suffix prop.

from genesia.