relick / touhou-song-sorter Goto Github PK

Should split up titles in the selection list by category i.e.
Touhou, Seihou, Secret Sealing Club, Akyuu's Untouched Score, and Extra/Bonus tracks

There's some data in the song list that, now songs are directly associated with title objects, could be transferred to the title objects. This would help reduce the massive amount of copy/paste noise in the song data list.
There will need to be a way to override however to allow e.g. the bonus CD category to have multiple album names, so this is not quite as straightforward as just moving the data.

At the moment, saving and loading is done by dumping all the arrays into jStorage and pulling them out again.

This should be optimised to use less data than it does by only storing what's actually necessary, and rebuilding the data on load.

In particular, it would be great to have a way to allow loaded sorts to get any bugfixes such as missing video links.

It'd be neat if you could filter by whether Zun is the composer or not - I'd like to rank everything he's written but not necessarily include things like the Fighting game stage themes.

Happy to help code that in if needed.

The song titles are okay but the game titles are a bit all over the place. I think it would be good to just restore them to their full original names and provide an english name in parentheses if necessary i.e. hisoutensoku, gouyoku ibun, and 100th black market.

It's mostly fine to do this but technically a bug because it will check for a selection and incorrectly start the sort + display an error if there isn't a valid selection - even though that's unrelated to the loading.

The main sort code is a bunch of global arrays with poor names and little commenting. It would be nice to bundle these up into proper objects with better names so that the code is more approachable and readable in future.

In particular, the undo code works by literally duplicating all the arrays and switching back to them - this is fairly rubbish and it would be nice to clean all that up.

May be fun to add the alternative MIDI soundtracks.
There are also a number of ZUN Touhou tracks that were released individually (e.g. ZUN's strange works) or on bonus CDs that are unaccounted for, or for 3rd party doujin releases - these should all be fixed up.

Add a greyed out disabled state for buttons when not able to be used e.g. Undo and Load

The games determined for inclusion don't really follow a pattern, but it's something like this:

• Any Touhou game or Hifuu album included
• Any game where ZUN composed most tracks included (i.e. shuusou gyoku and kioh gyoku but not banshiryuu)
• Any Touhou related track composed by ZUN added on its own.

To make this a bit more consistent, there's a few tracks that should be included that aren't, such as Independent Simulacrum or Drunkard's Lemuria, but also the ZUN focus is a bit muddied by the large number of non-ZUN compositions/arrangements that come from the fighting games. It would be good to actually attribute each track to the correct artists anyway, and then provide a way to filter down to the artists you actually care about.