Lint issue: Invalid package reference in io.grpc:grpc-core about awala-cogrpc-jvm HOT 7 CLOSED

So according to this:
grpc/grpc-java#5422
and
grpc/grpc-java@b7dd92e

We should not be having this issue...

I even inspected the code, and indeed they have the suppression on

Trying to dig deeper ⛏️

from awala-cogrpc-jvm.

Opened grpc/grpc-java#9661

from awala-cogrpc-jvm.

Thanks for looking into this @Filmaluco!

My main concern was that this lint issue could point to a real/potential issue in production, but according to the issue you linked to above, the worst that could happen is that a gRPC server could crash.

And since this lib is just a gRPC client, I think we should just silence it in the apps if we can't quickly find a way to silence it at the lib level.

As for the potential gRPC server issue, it could theoretically only affect the courier app (not the gateway), but it's been tested extensively in older phones, so I don't think we need to worry about it either. Since the problem is that certain Java classes would be missing, I reckon it'd be fairly easy to reproduce if it were actually happening.

from awala-cogrpc-jvm.

@gnarea the lint rules were already suppressing this, I opened the issue so not all apps that use the lib would have to do it... But with your approval, I will leave the lint suppression on the apps (such as the Android Gateway) and close this issue.

I will also try to re-open the issue on grpc/grpc-java just to try and have an answer on why this issue came back.

from awala-cogrpc-jvm.

Sounds good. Thank you!

from awala-cogrpc-jvm.

I tried taking out the <ignore path="**/grpc-core*.jar" /> on the Gateway app and it worked fine with cogrpc 1.1.31. The answer on grpc/grpc-java#9661 also didn't provide any alternative. Maybe we can close this @gnarea?

from awala-cogrpc-jvm.

Sounds good @sdsantos!

from awala-cogrpc-jvm.