rehabman / os-x-acpi-battery-driver Goto Github PK

ON my hack, battery dropped down from 14% to 5%

even though i have 2 batteries, its already patched. And this happened while it was running geekbench

Hi, I have HP Pavilion 15-bc207nl I used HP-Pavilion-n012tx patch which is the closest to my model, and I also use your battery kext. My battery has been recognized by the OS and the percentage is true but my laptop is not charging when Hackintosh is on. Is it about incorrect DSDT patch or something else?

Also I will be very very glad if you can make a DSDT patch for HP Pavilion 15-bc207nl.

Thanks!

System: HP Elitebook 2570p - Intel Core i5 3360m

It seems anytime AMT is involved in the BIOS, i cant get this to work. It will work and the battery % is correct and when AC is plugged in it will work correctly when i tell the bios to "Unconfigure AMT on next reboot" but as soon as a next reboot/shutdown takes place this goes back to not working!

What happens? Well it seems AMT is causing the battery % and status to be reported incorrectly. When plugged in It will also say "BATTERY IS NOT CHARGING"

There doesnt seem to be a way to permanently disable AMT either despite HP's own document stating howto get into the firmware management (CTRL+P)

Have no problems on a same model HP 2570p unit with a I5 processor (without 'V-Pro')

With the new kext it couldnt show battert icon when startup and must showit by myself and when restart it still disappear.

Old kext dont have this problem..

When this kext's loaded in Big Sur, the Energy Saver preferences icon is missing from the System Preferences app. Opening the .prefPane displays an error:

Evidently, on some machines this is not called on the workloop thread. When the target code calls back into check if there are any batteries discharging (from another thread), it results in deadlock (locking battery tracker IORecursiveLock) and battery status updates stop.

Will need to push this through a command gate, such that the code is executed on the workloop thread.

Note: I already have a fix for this sitting on the machine that I discovered it with, but that machine doesn't have network access, so it will be a bit...

I am experiencing an issue when power adapter is disconnected.

Charging state is automatically updated
It takes around 22 Seconds to switch Power source from "Power Adapter" to "Battery"

I use Lenovo X220

I have patched EC Multibyte and added BATC changing all the Notif methods to BATC

Additionally I had to patch device(AC) in order for ACPIACAdapter to be loadded by adding
Name (_PWR, Package (){0x18, 0x3})

Can this issue be related to DSDT or it is a bug in Driver ?

When it runs on battery and AC adapter is connected status icon is updated automatically

OSX Version is 10.14 Mojave Public Beta (18A389)

On 10.13, battery status will not be detected at startup.

Workaround: At login screen, unplug AC adapter, plug back in (or opposite if starting on battery power).

It appears to be a timing issue.

Note: Sometimes it works, but it is rare.

Battery status shows 0% at startup. Unplug and plug power cord solve the problem. Anything to do with the kext?

Thanks

After update to the latest git master (as of today, January 23, 2014), the kext still cannot find and properly show the battery status (reporting overall read timeouts), but the thing that changed is that the OS now thinks it is on battery power.

Can't there be a fallback to assume the system is always on AC if the information can't be read?

(I understand I must first fix the DSDT, but the discussion of that belongs elsewhere, I assume.)

I patched dsdt and install AcpiBatteryManager.kext, battery status is shown, but when adaper plug in, It's show battery not charge, from log, I found the charging bit never set, unplug in status is 1, plug in status is 0.

dig into dsdt，I found it just set PCI0.LPCB.EC0.MBST to status word.

If I reset EC, and boot to windows, then battery charge again, but once if I have boot macos, then back to windows, battery not charge again.
I dont know what cause this happen, blow is my _BST/UPBS/IVBS.

Method (_BST, 0, NotSerialized)
{
If (LEqual (^^PCI0.LPCB.EC0.ECOK, One))
{
If (^^PCI0.LPCB.EC0.MBTS)
{
UPBS ()
}
Else
{
IVBS ()
}
}
Else
{
IVBS ()
}

            If (LEqual (BRTE, Zero))
            {
                Store (0xFFFFFFFF, Index (PBST, One))
            }

            Return (PBST)
        }

Method (IVBS, 0, NotSerialized)
{
Store (Zero, Index (PBST, Zero))
Store (0xFFFFFFFF, Index (PBST, One))
Store (0xFFFFFFFF, Index (PBST, 0x02))
Store (0x2710, Index (PBST, 0x03))
}
Method (UPBS, 0, NotSerialized)
{
Store (B1B2(^^PCI0.LPCB.EC0.CUR0, ^^PCI0.LPCB.EC0.CUR1), Local0)
If (And (Local0, 0x8000))
{
If (LEqual (Local0, 0xFFFF))
{
Store (0xFFFFFFFF, Index (PBST, One))
}
Else
{
Not (Local0, Local1)
Increment (Local1)
And (Local1, 0xFFFF, Local3)
Store (Local3, Index (PBST, One))
}
}
Else
{
Store (Local0, Index (PBST, One))
}
Store (B1B2(^^PCI0.LPCB.EC0.BRM0, ^^PCI0.LPCB.EC0.BRM1), Local5)
If (LNot (And (Local5, 0x8000)))
{
ShiftRight (Local5, 0x05, Local5)
ShiftLeft (Local5, 0x05, Local5)
If (LNotEqual (Local5, DerefOf (Index (PBST, 0x02))))
{
Store (Local5, Index (PBST, 0x02))
}
}
If (LAnd (LNot (^^PCI0.LPCB.EC0.SW2S), LEqual (^^PCI0.LPCB.EC0.BACR, One)))
{
Store (FABL, Index (PBST, 0x02))
}
Store (B1B2(^^PCI0.LPCB.EC0.BCV0, ^^PCI0.LPCB.EC0.BCV1), Index (PBST, 0x03))
Store (^^PCI0.LPCB.EC0.MBST, Index (PBST, Zero))
}

After installing the kext (compiled for 32-bit mode) under either 10.6 and 10.7 on a Dell Inspiron 1520, automatic sleep doesn't work anymore. Sleep itself still works. 64-bit mode is untested as the laptop has GMA X3100 and thus requires a 32-bit kernel. I'm currently running a fully updated 10.6.8 install.

Hi RM,

As requested here :-

http://www.tonymacx86.com/mountain-lion-laptop-support/69472-battery-manager-fix-boot-without-batteries-58.html#post784853

When running dual batteries the battery menu icon % very often stalls and fails to update when discharging from (BAT2), manually forcing a refresh by de-selecting & re-selecting "Show Percentage" via the battery context menu usually updates the menu %. Once the laptop switches to discharging from BAT1 the menu % seems to update ok.

For further details on this issue see my post here:-

http://www.tonymacx86.com/mavericks-laptop-support/114961-jays-monkeybook-pro-ultimate-sony-vpc-se-customac-build-51.html#post782440

As discussed I believe that most of these issues are caused by a bug in the OSX battery monitor process. However you suggested that it may be possible to force an update on all batteries from within your kext:-

http://www.tonymacx86.com/mountain-lion-laptop-support/69472-battery-manager-fix-boot-without-batteries-58.html#post784587

Let me know if i can be of any further help when/if you come to address this issue.

Cheers
Jay

I think I've found a workaround for this. The conflict is in this code in AppleSmartBattery.cpp:

bool AppleSmartBattery::pollBatteryState(int path)
{
    // ...
    fProvider->getBatterySTA();
    if (fBatteryPresent)
    {
        if (fUseBatteryExtendedInformation)
            fProvider->getBatteryBIX();
        else
            fProvider->getBatteryBIF();
        if (fUseBatteryExtraInformation)
            fProvider->getBatteryBBIX();
    }
    fProvider->getBatteryBST();
    // ...
}

What happens is whenever the poll starts, _BIF is called on my machine and causes a brisk interruption in the movement of the cursor, and if the cursor is being moved when this happens, a leap/jump occurs.

I wonder if _BIF (not sure about the others) is really necessary for a frequent poll like this, so my proposal is to add a requirement for the execution of these taxing calls only when fStartupFastPoll || path == kNewBatteryPath .

I'm testing it right now and have yet observed any side effects.

battery indicator still 100%. Is there any way to solve it ?plz

What about machines that have more than just two battery devices? For example my asus zenbook ux331un has BAT0, BAT1 and BAT2. BAT0 located within both EC0 and H_EC while BAT1 and BAT2 are located under H_EC only. How should I apply this fix in my situation? I want to try this because I am having kernel panic when waking from sleep only if the computer is on battery power, while sleep works fine when on ac power.

here is cut and paste from /var/log/system.log - is this a DSDT issue?

Jan 29 11:33:00 Toms-Mac.local powerd[29]: Failed to read current rating(0xe00002f0)
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery::pollingTimeOut called
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery::pollBatteryState: path = 1
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBatteryManager::getBatterySTA called
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery::setBatterySTA: battery_status = 0x1f
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBatteryManager::getBatteryBIF called
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBatteryManager::getBatteryBIF: validateObject return 0x0
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery::setBatteryBIF: acpibat_bif size = 13
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery::setBatteryBIF: fPowerUnit = 0x0
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery::setBatteryBIF: fDesignCapacity = 84240
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery::setBatteryBIF: fMaxCapacity = 77720
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery::setBatteryBIF: fBatteryTech = 0x1
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery::setBatteryBIF: fDesignVoltage = 10800
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery::setBatteryBIF: fCapacityWarning = 3886
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery::setBatteryBIF: fLowWarning = 200
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery::setBatteryBIF: fDeviceName = 'Battery'
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery::setBatteryBIF: fSerialNumber = 'xxxxx'
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery::setBatteryBIF: fType = 'LION'
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery::setBatteryBIF: fManufacturer = 'LENOVO'
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBatteryManager::getBatteryBST called
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery::setBatteryBST: acpibat_bst size = 4
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery::setBatteryBST: fPowerUnit = 0x0
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery::setBatteryBST: currentStatus = 0x0
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery::setBatteryBST: fCurrentRate = 0
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery::setBatteryBST: fCurrentCapacity = 76620
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery::setBatteryBST: fCurrentVoltage = 12068
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery::setBatteryBST: Calculating for WATTS
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery::setBatteryBST: fCurrentRate = 0
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery::setBatteryBST: fCurrentCapacity = 7094
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery::setBatteryBST: fAverageRate = 0
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery: Battery is charged.
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery::constructAppleSerialNumber called
Jan 29 11:33:30 Toms-Mac kernel[0]: AppleSmartBattery::rebuildLegacyIOBatteryInfo called
Jan 29 11:33:30 Toms-Mac.local powerd[29]: Failed to read current rating(0xe00002f0)

SSDT-BATC.dsl not compiling via maciasl 1.4

I use your last BatteryManager kext (download from here) and I encounter an "issue" with it about the battery status icon.

When I'm charging the battery, normal icon (the battery with the "power" inside). However, when the battery is finished to be charge, the battery icon change to the default battery one - the one you've got in fact when you're on battery (and normally discharging it) remaining at 100% charge (and when I check the status, it says that the power is coming from battery, not from wall plug). So, the icon didn't change to the normal "electrical plug" one. It is the same if I remove the charger, let the battery discharge only few % (I know that in this case, battery will not charge after to avoid "memory" ) and plug again the transformer on the laptop, the battery icon doesn't change and remain "on battery"... However, for sure, battery % didn't decrease...

I don't have this behavior (in fact I've got the normal one) with the Zprood kext (the old from) from here http://www.insanelymac.com/forum/topic/272...nager-for-lion/. However, this kext is not able to read correctly battery count cycle for my battery.

So, can I help you to track this ?

Thanks.

Fred.

P.S.: I've got an Asus Zenbook UX32LN patched with your MacIASL "repository" change 4.08. I can forward you my patched DSDT and SSDTs if necessary.

Does not work Slightly dim the display while on battery power. (10.13)
Starts working only after turn OFF and turn ON checkbox "Slightly dim the display while on battery power".
v1.81.3

The menu bar power indicator doesn't update the battery/power status properly in High Sierra. (Works fine in Sierra).

The ACPI itself is working fine, as coconutBattery updates fine when the device is plugged in/unplugged and the battery percentage changes, even in High Sierra.

Hi,
I have two problems with ACPIBatteryManager,

My Acer Aspire 5741G show Battery status with this kext and patched DSDT before 10.10.3 update. Now refuse to load battery status on menubar and sleep stop working.
Looking at debug log and ioreg all look correct.

He´re logs, ioreg and current DSDT. https://drive.google.com/folderview?id=0BzLilIVbrwhQfmtBc0QxRFhaN2lRQXJnaW1wNkc1VEtqOFlVRGdnbDJIVm9XcE8ydWZuOEE&usp=sharing

i am a beginner ,please tell me.. thx

Hello，Rehabman！

This is a 16-bit byte：
MCUR, 16,
Store (^^PCI0.LPCB.EC0.ECRD (RefOf (^^PCI0.LPCB.EC0.MCUR)), Local5)

and I use the B1B2：
MCU0, 8,MCU1, 8,
Store (^^PCI0.LPCB.EC0.ECRD (RefOf (B1B2(^^PCI0.LPCB.EC0.MCU0,^^PCI0.LPCB.EC0.MCU1))), Local5)

He will report an error：
37462, 6126, syntax error, unexpected PARSEOP_CLOSE_PAREN, expecting PARSEOP_EXP_INDEX_LEFT

I think the problem is“refof”
I don't know what should I do，can you help me？
Thank you！

Hi, I experienced a little bug but I wasn't sure where to post the issue, here or open a ticket on Clover SourceForge.

As I have seen you more active and I saw all your configs are made with Clover as boot maybe you experienced this issue.

I have originally generated a DSDT with MaciASL and applied only patches from your repo. The battery icon was working really well with Chameleon but since I have changed to Clover the battery icon disappeared.

HWMonitor show the battery status wich is weird.

Your Battery Kext loaded correctly and the DSDT is also loading fine because I also applied the fix for the screen brightness and the brightness bar appear on Settings>Displays.

Also the FakeSMC (I know this is a different driver) is also not working anymore. I noticed this because the Voltage, CPU usage doesn't show up on HWMonitor.

I have used this Clover config from your Clover-Laptop-Config repo
https://github.com/RehabMan/OS-X-Clover-Laptop-Config/blob/master/config_HD3000_1366x768.plist

I am attaching some screenshots from IOReg wich shows that everything should be ok but it's not.

ACPI battery manager is able to detect more than 1 battery merge it, and show it to macos bla bla bla. Any chance a client can be made for this kext that shows the percentage of both batteries in the laptop?

See: http://www.insanelymac.com/forum/topic/322196-macos-sierra-10124-is-out/?p=2393652

Hi. Running OS X Yosemite on ASUS Vivobook s500ca here, and trying to use this kext for battery. However, although your kext makes the battery indicator appear, it is always at 0%. Although this is my first attempt at hackintosh, I suspect it has something to do with DSDT needing to be patched. I don't know what it is (and I don't think I have one), but I think I saw something about that in Chameleon Wizard (I'm using Chameleon as a bootloader). If my DSDT does need to be patched, can you please walk me through it?

Hello RehabMan.
I use your kext and dsdt patch (battery_HP-DV7-6xxx.txt) for the battery
Before version 10.10.3 everything worked perfectly.
(The indicator does not appear or does not work at all)
And this problem still occurs in some people.

You can see what is the reason?
I can provide reports on demand.

Some DSDTs will provide an AC status update and then provide incorrect information about the state of the charge/discharge on the battery. That is, they will notify that AC is connected, but then not show battery charging until some delay.

To work around this, the battery manager should poll more often after an AC state change.

Kext installed to S/L/E
DSDT appropriately patched
Kext working perfectly in High Sierra
Kext in Sierra displays the battery percentage correctly but gives a low battery warning.

DSDT.aml.zip

I'm using the Thinkpad T440s with 2 batteries without the battery-merge hack. its running quite well. except a minor bug: when one battery is empty, its shown with a red battery indicator symbol in the menu bar as desired. but after bios switch to the second (fully charged) battery, it keeps red instead of switching to a black (non critical) feedback symbol, although it show the percentage correctly.

Hi,

Surface Gen 5 devices (Surface Book 2 / Surface Pro 6 / Surface Laptop, etc.) uses UART to fetch its battery status, which makes their DSDT does not contain "EmbeddedControl" at all.

However, in jakeday/linux-surface#28 , some legendary hackers finished the research and provided a proof of concept: https://gist.github.com/qzed/01a93568efb863f1b7887f0f375c03fc

It then becomes a linux kernel patch ( jakeday/linux-surface#321 ). But before that, people are using cron jobs to run the POC script and update their battery status using its output.

Is there a way we could achieve something similar? Or should we work with https://github.com/VoodooI2C/VoodooI2C as they may have some experiences dealing with UART?

Thanks!