reflectiveearth / reflective-potential Goto Github PK

Is your feature request related to a problem? Please describe:

The current figures produced by the visualize notebook do not match those in the article submitted to Environmental Research Communications.

Describe the solution you'd like:

Update the visualize notebook to produce PNG and EPS files matching those in the article submitted to Environmental Research Communications.

Describe alternatives you've considered:

The desired figures could be created in a notebook other than visualize, however that might be confusing and needlessly complex.

Additional context:

The schematic in Figure 1 of the Environmental Research Communications article could be added to the repo assets and README file.

Is your feature request related to a problem? Please describe:

Salamanca and coauthors published an article in Environmental Research Letters that included experimental evidence and model evaluation of top-of-atmosphere radiative cooling associated with cool roofs [1]. Their method distinguishes between roof albedo and the surrounding area albedo. The current reflective-potential analysis does not distinguish between the roof and surrounding area. Rather, for the upper bound of reflectivity potential it assumes that the roof and surrounding area both have an albedo = 1. A critical reviewer could argue that this is unphysical. Even if many surfaces are brightened, it is unlikely that all surfaces will be brightened.

Describe the solution you'd like:

Update the potential surface-reflected outgoing solar radiation calculation to separately consider the intervention albedo and surrounding area albedo. Surrounding area albedo is already calculated as a parameter in the analysis, so updating the equation should be trivial. With this change, upwelling radiation reflected by the atmosphere back to the surface is assumed to reflect according to the surrounding area albedo.

Describe alternatives you've considered:

Reflective Earth has already discussed the alternative of leaving the potential surface-reflected outgoing solar radiation calculation as is. The utility of the existing approach is likely lower than that of the Salamanca et al. approach.

Additional context:

[1] Salamanca F et al 2012 Environ. Res. Lett. 7 044007 doi: 10.1088/1748-9326/7/4/044007

Describe the bug

The issue template chooser offers 4 choices: bug report, feature request, custom issue, or blank issue. The difference between custom issue and blank issue could be confusing.

To Reproduce

Steps to reproduce the behavior:

1. Open the reflective-potential repo
2. Navigate to the issues tab
3. Click new issue
4. View the template choices

Expected behavior

The issue template chooser offers 3 choices: bug report, feature request, or other issue. Blank issue is no longer an option.

Screenshots

Development Environment (please complete the following information):

• OS: macOS
• OS Version: Catalina 10.15.7
• Python Versions: N/A

Additional context

None.

Is your feature request related to a problem? Please describe:

Results based on a single dataset (e.g. ECMWF ERA5) may not be robust if that dataset has systematic biases.

Describe the solution you'd like:

The robustness of the results based on ECMWF ERA5 could be demonstrated by replicating them using an independent dataset. I suggest the NASA CERES EBAF dataset provided by Langley Research Center. According to NASA, this Energy Balance and Filled dataset is suitable for analysis of variability at the intra-seasonal, inter-annual, and longer time scales. Furthermore, the TOA net flux is constrained to the ocean heat storage.

It has observed top-of-atmosphere and computed surface all-sky and clear-sky fluxes on a 1°x1° grid. Data are available 2003 through June 2021. We could produce a supplementary figure that compares results based on the two datasets with a common time period (e.g. 2003 through 2020).

Describe alternatives you've considered:

Other reanalysis products could be utilized, e.g. NCEP-DOE Reanalysis 2. The reliability of these reanalysis fields is unknown at this time [prior to literature review].

Additional context:

These results should be referenced in the main text, however any figures or tables should be separated into supplementary materials.

Describe the bug

The conda environment files available in the repository are inconsistent across the platforms (linux, macOS) and incomplete in some cases. A particular issue appears with the ingest environment.

To Reproduce

Steps to reproduce the behavior:

1. Open notebook associated with an environment file.
2. Run all cells.
3. See errors.

Expected behavior

No errors occur when running all notebooks on both linux and macOS.

Additional context

Eventually it would be nice to leverage GitHub Actions to automatically check the environment files and notebooks.

GitHub Discussions is a collaborative communication forum for communities around open source projects. This is likely a better resource than the current support resource: the sole maintainer's email address.

• Enable GitHub Discussions for reflective-potential
• Make an initial post on Discussions
• Describe our use of Discussions in SUPPORT.md

Reflective Earth Foundation aspires to embody the principles open science in its work. Where code is used to generate insights, the organization wants to open source it for the common good. This project repository has been identified as an initial candidate for open sourcing. Prior to making the repository public, the following documentation should be added via a PR:

• Add a license
• Add a code of conduct
• Add contributor guidelines
• Add support resources
• Add a funding file
• Add a changelog

Offering contributors templates for Pull Requests and Issues will help to make the project's documentation more standard and understandable. GitHub maintains some documentation describing the why, how, and what behind these templates.

Task list

• Add a Pull Request template in a hidden directory
• Add an Issue template for a Bug report in a hidden directory
• Add an Issue template for a Feature request in a hidden directory
• Add a blank Issue template in a hidden directory
• Add a configuration file for the issue templates