refinedmods / refinedstorage2 Goto Github PK

Refined Storage is a mass storage mod for Minecraft that offers the player a network-based storage system, allowing them to store items and fluids on a massively expandable device network.

License: MIT License

Java 100.00%

minecraft minecraft-mod refinedstorage fabricmc mod fabric-mod fabric refinedstorage2 java forge

refinedstorage2's Introduction

Refined Storage 2

Refined Storage is a mass storage mod for Minecraft that offers the player a network-based storage system, allowing them to store items and fluids on a massively expandable device network.

About

Items and fluids can be stored in one of the many storage capabilities that the mod offers. Any storage devices connected to the same network are accessible to the player through one simple Grid interface, allowing the player to access the inventories of many devices through a single unified GUI.

This mod not only adds storage solutions, but also devices that can be used to manipulate items and blocks in the world and from within the system, such as importers, exporters, constructors, destructors, and more! There are also devices in this mod that allow the player to setup auto-crafting, allowing the crafting of complex recipes in a few simple clicks.

Building

Clone the repository and import the Gradle project.

Contributing

See CONTRIBUTING.md.

Support

See SUPPORT.md.

Changelog

See CHANGELOG.md.

refinedstorage2's People

Contributors

Stargazers

Watchers

Forkers

schwabe93 mrlast98 gigili bulldog98 kirbosoftware alex-van-vliet mrjinx453 archowlen mrcorpz

refinedstorage2's Issues

Disk drives are not updating their led state

Grid

Grid only allows spaces on the top level for implicit AND

I want to use (iron ore) || dirt as well.

Incompatiblity with WTHIT

https://www.curseforge.com/minecraft/mc-mods/wthit

While trying to post the log so you can check the error, I think I found some other problem with https://www.curseforge.com/minecraft/mc-mods/wthit
https://paste.ee/p/Amo0q#s=0&l=252 (line 252 in case the link does not work properly)
And this is WailaErrorOutput.txt https://paste.ee/p/QipM2

[01:38:22] [Render thread/ERROR]: [WTHIT] Caught unhandled exception : [class mcp.mobius.waila.plugin.core.component.BlockComponent] java.lang.NullPointerException: Cannot invoke "com.refinedmods.refinedstorage2.platform.fabric.api.network.node.container.PlatformNetworkNodeContainerImpl.getRedstoneMode()" because the return value of "com.refinedmods.refinedstorage2.platform.fabric.block.entity.FabricNetworkNodeContainerBlockEntity.getContainer()" is null
[01:38:22] [Render thread/ERROR]: [WTHIT] See .waila/WailaErrorOutput.txt for more information

Note: WTHIT is a fork of Hwyla, that is a fork of Waila, and is the currently maintained waila like mod for Fabric

Exporter

Modes: round robin, random, first-available

You can only place 1 creative controller in a network

Disk Drive is never inactive

Add extra large Grid size

Grid size options (rows) currently are:

small:3
medium: 5
large: 8
stretch: 18 (@ 1920x1080)

I would suggest adding XLarge : 12, since the jump from 8 to 18 rows is kind of big, and a size in between would be nice to have. For me Large feels a bit to small, and Stretch at my resolution is a bit to large.

Maybe the current settings were fine when RS first came out, and monitors/video cards did not support the current much larger resolutions. About 67% of gamers on steam use 1920x1080 (source: https://store.steampowered.com/hwsurvey)

Storage Housing

Fix block hardness

Machine Casing

Crash when clicking in ModMenu when clothconfig is not loaded

Navigating to the controller entry doesn't work for the controller variants in Patchouli

Navigating to the controller entry doesn't work for the controller variants.

Got my RS test instance set up! The guidebook does not work with creative controllers, I guess that could be expected, but it would be nice if they did, just like the normal controllers.

Exact mode is broken

Since I have refactored the resource API exact mode no longer works.

Speed Upgrade

Scrolling items on the cursor no longer works

Processors

Verify chunk loading behavior

Upgrade

Should also tell in the upgrade tooltip on which machines it can be used.

Cable

Creative Controller

Insert only extract mode still shows items in Grid

When you put a storage in "insert-only" mode, the items stay visible in the Grid while they are not extractable.

This is a difference from RS 1.x.

Figure out what I want to do with this.

Storage Blocks

Item IDs shifting issue

I found a bug!
I added some new mods, and when I next checked my RS inventory, all the items were different items
This only happened to items in RS, no other storage
I don't think ALL items swapped, some stuff looks right

Importer

Silicon

Rendering crash

java.lang.IllegalArgumentException: Cannot get property class_2754{name=direction, clazz=class com.refinedmods.refinedstorage2.fabric.util.BiDirection, values=[NORTH, EAST, SOUTH, WEST, UP_NORTH, UP_EAST, UP_SOUTH, UP_WEST, DOWN_NORTH, DOWN_EAST, DOWN_SOUTH, DOWN_WEST]} as it does not exist in Block{minecraft:air}
	at Not Enough Crashes deobfuscated stack trace.(1.17.1+build.39)
	at net.minecraft.state.State.get(State:98)
	at com.refinedmods.refinedstorage2.fabric.render.entity.DiskDriveBlockEntityRenderer.render(DiskDriveBlockEntityRenderer.java:56)
	at com.refinedmods.refinedstorage2.fabric.render.entity.DiskDriveBlockEntityRenderer.render(DiskDriveBlockEntityRenderer.java:22)
	at net.minecraft.client.render.block.entity.BlockEntityRenderDispatcher.render(BlockEntityRenderDispatcher:84)
	at net.minecraft.client.render.block.entity.BlockEntityRenderDispatcher.method_23081(BlockEntityRenderDispatcher:73)
	at net.minecraft.client.render.block.entity.BlockEntityRenderDispatcher.runReported(BlockEntityRenderDispatcher:98)
	at net.minecraft.client.render.block.entity.BlockEntityRenderDispatcher.render(BlockEntityRenderDispatcher:73)
	at me.jellysquid.mods.sodium.client.render.SodiumWorldRenderer.renderTileEntities(SodiumWorldRenderer.java:272)
	at net.minecraft.client.render.WorldRenderer.handler$ckm000$onRenderTileEntities(WorldRenderer:10399)
	at net.minecraft.client.render.WorldRenderer.render(WorldRenderer:1278)
	at net.minecraft.client.render.GameRenderer.renderWorld(GameRenderer:1026)
	at net.minecraft.client.render.GameRenderer.render(GameRenderer:810)
	at net.minecraft.client.MinecraftClient.render(MinecraftClient:1112)
	at net.minecraft.client.MinecraftClient.run(MinecraftClient:728)
	at net.minecraft.client.main.Main.main(Main:217)
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at net.fabricmc.loader.game.MinecraftGameProvider.launch(MinecraftGameProvider.java:234)
	at net.fabricmc.loader.launch.knot.Knot.launch(Knot.java:153)
	at net.fabricmc.loader.launch.knot.KnotClient.main(KnotClient.java:28)

---- Minecraft Crash Report ----
// My bad.

Time: 8/19/21, 8:31 PM
Description: Rendering Block Entity

java.lang.IllegalArgumentException: Cannot get property class_2754{name=direction, clazz=class com.refinedmods.refinedstorage2.fabric.util.BiDirection, values=[NORTH, EAST, SOUTH, WEST, UP_NORTH, UP_EAST, UP_SOUTH, UP_WEST, DOWN_NORTH, DOWN_EAST, DOWN_SOUTH, DOWN_WEST]} as it does not exist in Block{minecraft:air}
	at Not Enough Crashes deobfuscated stack trace.(1.17.1+build.32)
	at net.minecraft.state.State.get(State:98)
	at com.refinedmods.refinedstorage2.fabric.render.entity.DiskDriveBlockEntityRenderer.render(DiskDriveBlockEntityRenderer.java:56)
	at com.refinedmods.refinedstorage2.fabric.render.entity.DiskDriveBlockEntityRenderer.render(DiskDriveBlockEntityRenderer.java:22)
	at net.minecraft.client.render.block.entity.BlockEntityRenderDispatcher.render(BlockEntityRenderDispatcher:84)
	at net.minecraft.client.render.block.entity.BlockEntityRenderDispatcher.method_23081(BlockEntityRenderDispatcher:73)
	at net.minecraft.client.render.block.entity.BlockEntityRenderDispatcher.runReported(BlockEntityRenderDispatcher:98)
	at net.minecraft.client.render.block.entity.BlockEntityRenderDispatcher.render(BlockEntityRenderDispatcher:73)
	at me.jellysquid.mods.sodium.client.render.SodiumWorldRenderer.renderTileEntities(SodiumWorldRenderer.java:301)
	at net.minecraft.client.render.WorldRenderer.handler$fga000$onRenderTileEntities(WorldRenderer:18149)
	at net.minecraft.client.render.WorldRenderer.render(WorldRenderer:1278)
	at net.minecraft.client.render.GameRenderer.renderWorld(GameRenderer:1026)
	at net.minecraft.client.render.GameRenderer.redirect$dja000$redirectRenderingWorld(GameRenderer:10622)
	at net.minecraft.client.render.GameRenderer.render(GameRenderer:810)
	at net.minecraft.client.MinecraftClient.render(MinecraftClient:1112)
	at net.minecraft.client.MinecraftClient.run(MinecraftClient:728)
	at net.minecraft.client.main.Main.main(Main:217)
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:567)
	at net.fabricmc.loader.game.MinecraftGameProvider.launch(MinecraftGameProvider.java:234)
	at net.fabricmc.loader.launch.knot.Knot.launch(Knot.java:153)
	at net.fabricmc.loader.launch.knot.KnotClient.main(KnotClient.java:28)

Fluid Storage Parts

Fluid Storage Blocks

Cores

Unary operators after each other are broken

Controller

Block of Quartz Enriched Iron

Item Storage Parts

Storage Disk

Energy issues

also, I know it's configurable, but is the power usage meant to feel so power hungry and so low internal storage compared to the forge version? I mean I had all kinds of power issues on forge, and RS would run off internal storage for quite a long time. On this version, the most basic possible setup, of a disk drive, a grid, and a controller (not even any disks yet) eats more power than I can output with 3 ultimate solar panels, and a Thermal Generator (all from TR), and if disconnected from power drains it's internal battery in less than 1 second.

Compatibility with block entity moving mods

https://www.curseforge.com/minecraft/mc-mods/carrier

When you shift rclick a grid for example, this is the error: https://paste.ee/p/oRytq and the grid block is still visible. When you try to interact with the grid with rclick, it vanishes

Storage trackers aren't saved

Fluid Grid

Wrench

Refined Storage oddities with Mystic Agriculture

Version and correlating: Using mod version 1.9.15 with Refined Storage Addons 0.7.3 under FTB Oceanblock ver 1.7.0

Issue(s):

Reoccurrence of a previous autocrafting issue with mystical agriculture supremium #788
Replacing Master Infusion Crystal with with degradable Infusion Crystal if 'Exact' is not checked in pattern.

Explanation:

Issue with requiring multiples of a functionally infinite item as part of a recipe unable to be worked around as there is no method to force processing.
Using a standard Prudentium recipe with a Master Infusion Crystal and no degradable Infusion crystal.

Using the 'Exact' option in the pattern works as expected with Master Infusion Crystal returning into inventory system.

Unchecking processes as expected besides the Master Infusion Crystal converting to a standard Infusion Crystal with 999 uses remaining.