Code Monkey home page Code Monkey logo

Comments (6)

msutkowski avatar msutkowski commented on June 16, 2024 1

@BretMishler Did you clone this repo? Or did you follow the instructions and create your project as a template as instructed?

yarn create react-app my-app --template redux-typescript

If you run that and follow the instructions in your terminal, it'll work.

from redux-templates.

markerikson avatar markerikson commented on June 16, 2024

Yep. The repo itself isn't cloneable as-is. It's the codebase for the published cra-template-redux-typescript package, which is only meant to be used through the create-react-app CLI command.

from redux-templates.

BretMishler avatar BretMishler commented on June 16, 2024

@msutkowski @markerikson I did clone the repo; you're correct.

Though I don't feel that it should come to a surprise to anyone why I, or others, would clone this repo when the Redux and Redux Toolkit documentation says,

The recommended way to start new apps with React and Redux is by using the official Redux+JS template or Redux+TS template for Create React App

both have links that point to this repo here, not the one at the Create React App repo.

While it may be obvious to you guys from the docs that this is a "template" only, it wasn't obvious to me and Im not sure it would be obvious to others as well, especially given the quote above. Just some thoughts.

Thank you guys so much for the work you do.

from redux-templates.

markerikson avatar markerikson commented on June 16, 2024

Hmm. The README for this repo does say, up front:

Usage:
npx create-react-app my-app --template redux

as do both docs "Getting Started" pages.

I suppose we could remove the links to these template repos, since in that sense the repos don't actually matter for setting up a project?

from redux-templates.

BretMishler avatar BretMishler commented on June 16, 2024

You're absolutely right to point to

Usage:
npx create-react-app my-app --template redux

as proof that the documentation mentions how to install the Create React App with the Redux template.

Though because of my prior experiences, which I assume to be commonly reinforced amongst others who are new to spa apps, Im used to being able to just clone a repo and then npm start (build) that repo. Being new, I didn't realize until the learning experience just now that

  1. Cloning this repo
  2. Following this repo's documentation

were going to result in two different outcomes (the former downloads an unconfigured template, the later downloads a buildable project with that template preconfigured). With that said, I think removing the links to these templates would do a disservice to individuals who can distinguish the difference between cloning a template and cloning the actual Create React App project with said template. Maybe there could be prefixed to the README here that cloning this project clones a template that will need to be integrated manually with the react app and that for a works-out-of-the-box experience, it's recommended to

npx create-react-app my-app --template redux

But if this feels like it caters to too small an audience, I can concede to that point of view. Again, thank you.

from redux-templates.

markerikson avatar markerikson commented on June 16, 2024

Sure, can you file a PR to this repo to update the wording? We can apply it to the TS template as well after that.

from redux-templates.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.