Code Monkey home page Code Monkey logo

Comments (5)

markerikson avatar markerikson commented on June 1, 2024

TS supports cyclic types just fine, since that's only a compile-time thing. There's no bug here.

from redux-templates.

nickmccurdy avatar nickmccurdy commented on June 1, 2024

@markerikson Is it possible that this is referring to cyclic imports (not cyclic types)? I believe that would be an issue with TypeScript.

@sa1dai If you're not sure, it would help to see a Code Sandbox or repository reproducing the issue.

from redux-templates.

markerikson avatar markerikson commented on June 1, 2024

Nope, the listed concern is about importing RootState back into counterSlice, which is to be expected and works fine.

from redux-templates.

maxjava-dev avatar maxjava-dev commented on June 1, 2024

@nickmccurdy @markerikson
It is about cyclic types. To be completely clear: I started to integrate template to my project and got this error. After @markerikson comment that its not the issue cause of TS, I googled, and found this thread where states that it is not the issue and should not be even occur. I am going to use this and overcome error.

from redux-templates.

xpol avatar xpol commented on June 1, 2024

Use Type-Only Imports introduced by typescript 3.8 in counterSlice.ts would fix it.

Change this line:

import { AppThunk, RootState } from '../../app/store';

to

import type { AppThunk, RootState } from '../../app/store';

from redux-templates.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.