Permit errors='surrogateescape' and others about hiredis-py HOT 8 CLOSED

I have now added Py_DECREF on the temporary objects. Otherwise, if I add

fprintf(stderr, "codecs refs=%ld", (long)Py_REFCNT(codecs));

then I see the reference count increasing on each call.

from hiredis-py.

Fair point. Would you like to do this and send a PR?

from hiredis-py.

Which behaviour do you want: don't validate the encoding, or validate it via codecs.lookup_error ? The former seems more natural to me, but is a minor behaviour change.

from hiredis-py.

I prefer the latter one. It's the current behavior.
If we don't validate the coding in the Reader_init phase, it is possible that reader.gets will raise a LookupError. Maybe I'm a little pedantic but it's kind of an API change.

from hiredis-py.

OK - can you tell me the correct way to call codecs.lookup_error from C ?

from hiredis-py.

Import module: https://docs.python.org/3/c-api/import.html#c.PyImport_ImportModule
Call method: https://docs.python.org/3/c-api/object.html#c.PyObject_CallMethod

from hiredis-py.

OK, done. However I'm not sure if my unit test test_decode_error_with_surrogateescape_errors will work for python2.7; it could be made conditional or removed entirely.

from hiredis-py.

Fixed it

from hiredis-py.