Comments (9)
chayim
commented on July 20, 2024
@mcepl Have you seen vendor/sdsalloc.h in the codebase? You need to ensure you update submodules as well.
git submodule update --init --recursive is your friend
from hiredis-py.
mcepl
commented on July 20, 2024
@mcepl Have you seen vendor/sdsalloc.h in the codebase? You need to ensure you update submodules as well.
git submodule update --init --recursive is your friend
Given I am trying to use tarball from https://files.pythonhosted.org/packages/source/h/hiredis/hiredis-2.2.2.tar.gz I would hope it is included. It actually is, but I would prefer if I could use include files from the hiredis package itself, not the vendored one.
from hiredis-py.
Apteryks
commented on July 20, 2024
I'm in the same situation, trying to update this package to 2.2.2 on GNU Guix; there's no sdalloc.h file in hiredis 1.1.1:
$ find /gnu/store/0clwbra3j29m97rajyi5y83lm29s2636-hiredis-1.1.0/include/
/gnu/store/0clwbra3j29m97rajyi5y83lm29s2636-hiredis-1.1.0/include/
/gnu/store/0clwbra3j29m97rajyi5y83lm29s2636-hiredis-1.1.0/include/hiredis
/gnu/store/0clwbra3j29m97rajyi5y83lm29s2636-hiredis-1.1.0/include/hiredis/read.h
/gnu/store/0clwbra3j29m97rajyi5y83lm29s2636-hiredis-1.1.0/include/hiredis/async.h
/gnu/store/0clwbra3j29m97rajyi5y83lm29s2636-hiredis-1.1.0/include/hiredis/alloc.h
/gnu/store/0clwbra3j29m97rajyi5y83lm29s2636-hiredis-1.1.0/include/hiredis/sockcompat.h
/gnu/store/0clwbra3j29m97rajyi5y83lm29s2636-hiredis-1.1.0/include/hiredis/adapters
/gnu/store/0clwbra3j29m97rajyi5y83lm29s2636-hiredis-1.1.0/include/hiredis/adapters/ae.h
/gnu/store/0clwbra3j29m97rajyi5y83lm29s2636-hiredis-1.1.0/include/hiredis/adapters/glib.h
/gnu/store/0clwbra3j29m97rajyi5y83lm29s2636-hiredis-1.1.0/include/hiredis/adapters/ivykis.h
/gnu/store/0clwbra3j29m97rajyi5y83lm29s2636-hiredis-1.1.0/include/hiredis/adapters/libev.h
/gnu/store/0clwbra3j29m97rajyi5y83lm29s2636-hiredis-1.1.0/include/hiredis/adapters/libevent.h
/gnu/store/0clwbra3j29m97rajyi5y83lm29s2636-hiredis-1.1.0/include/hiredis/adapters/libhv.h
/gnu/store/0clwbra3j29m97rajyi5y83lm29s2636-hiredis-1.1.0/include/hiredis/adapters/libuv.h
/gnu/store/0clwbra3j29m97rajyi5y83lm29s2636-hiredis-1.1.0/include/hiredis/adapters/macosx.h
/gnu/store/0clwbra3j29m97rajyi5y83lm29s2636-hiredis-1.1.0/include/hiredis/adapters/poll.h
/gnu/store/0clwbra3j29m97rajyi5y83lm29s2636-hiredis-1.1.0/include/hiredis/adapters/qt.h
/gnu/store/0clwbra3j29m97rajyi5y83lm29s2636-hiredis-1.1.0/include/hiredis/hiredis.h
/gnu/store/0clwbra3j29m97rajyi5y83lm29s2636-hiredis-1.1.0/include/hiredis/sds.h
I find it curious that a 'vendored' file doesn't exist upstream; is it something added by hiredis-py?
I would also like to be able to simply link against a system-provided hiredis.
from hiredis-py.
Apteryks
commented on July 20, 2024
The https://github.com/redis/hiredis/blob/v1.1.0/sdsalloc.h file seems to contain 3 re-definitions, perhaps for backward compatibility purpose? hiredis-py could probably be adjusted to use alloc.h and the originally named definitions it contains instead.
from hiredis-py.
Apteryks
commented on July 20, 2024
@mcepl hi! you may be interested in #159 and #161 to allow using a system-provided hiredis library.
from hiredis-py.
mcepl
commented on July 20, 2024
Thank you, https://build.opensuse.org/request/show/1072918
from hiredis-py.
chayim
commented on July 20, 2024
@Apteryks where did you get a hiredis 1.1.1 - the last release I see is 1.1.0
from hiredis-py.
Related Issues (20)
- Cannot install on alpine linux HOT 1
- Differentiating between bool False and not-enough-data HOT 1
- Wheel support for python 3.10
- Bump hiredis version to 1.0.2 HOT 1
- New release for cp3.10 is not on pypi HOT 6
- Can not decode resp3's big number type HOT 4
- pip install failing for version 2.0.0 python 3.10 HOT 2
- Can't install hiredis HOT 2
- C99 errors with older gcc HOT 4
- PUSH type not distinguishable from ARRAY type in RESP3 HOT 4
- Release for supporting Python 3.10 HOT 9
- Support newest hiredis release 1.1.0
- Source tarballs unavailable on pypi? HOT 5
- Changelog entry missing for 2.1.0
- Support dispatch/manual and tagged releases
- Windows wheels fail to build due to ssize_t redefinition HOT 2
- CI needs to properly account for all buildwheels attempts - at least in some labelled cases HOT 1
- Support garbage collection in Reader HOT 1
- Tag mismatch for 2.2.3/2.3.0 release HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hiredis-py.