redhat-actions / oc-installer Goto Github PK

Version

redhat-actions/oc-installer@v1

Describe the bug

oc-installer does not understand oc_version such as 3.11.375-1 (it will strip anything after the bugfix number, in this case, it will change the input to 3.11.375) - works great with 3.11.374 though.

Steps to reproduce, workflow links, screenshots

With such configuration:

      - name: Install oc
        uses: redhat-actions/oc-installer@v1
        with:
          oc_version: '3.11.375-1'

oc-installer will fail to install oc :

Run redhat-actions/oc-installer@v1
  with:
    oc_version: 3.11.375-1

Installing oc version 3.11.375
Found oc version 3.11.375 at https://mirror.openshift.com/pub/openshift-v3/clients/3.11.375/linux/oc.tar.gz
Downloading oc from https://mirror.openshift.com/pub/openshift-v3/clients/3.11.375/linux/oc.tar.gz ...
Error: Error: Unexpected HTTP response: 404

Although 3.11.375-1 exists: https://mirror.openshift.com/pub/openshift-v3/clients/3.11.375-1/linux/

Version

redhat-actions/oc-installer@v1

Describe the bug

Run redhat-actions/oc-installer@v1
  with:
    oc_version: 4.7.0
Installing oc version 4.7
Found oc version 4.7 at https://mirror.openshift.com/pub/openshift-v4/clients/oc/4.7/linux/oc.tar.gz
Downloading oc from https://mirror.openshift.com/pub/openshift-v4/clients/oc/4.7/linux/oc.tar.gz ...
Error: Error: Unexpected HTTP response: 404-->

Is there a reason why this Github action is pointed at this particular location of oc binaries? At https://mirror.openshift.com/pub/openshift-v4/clients/oc/$__DEPRECATED_LOCATION__PLEASE_READ__.txt it indicates this is a deprecated location and to use https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp/

eg oc_version: 5 results in :

Error: Error: Version is written in an unknown format

Version

redhat-actions/oc-installer@v1

Using the following "with" block:
with:
oc_version: "4.6"

Describe the bug

When the oc installer action is fetching the mirror path for the binary, it's still using the clients/oc/4.6/linux/ subpath. Upon fetching the binary this results in a failure (403).

The mirror has been changed to use a x86_64/clients/ocp/ subpath now according to:
https://mirror.openshift.com/pub/openshift-v4/clients/oc/4.6/linux/$__DEPRECATED_LOCATION__PLEASE_READ__.txt

Steps to reproduce, workflow links, screenshots

Run the action, the get should produce a 403 since the url is of the form https://mirror.openshift.com/pub/openshift-v4/clients/oc/4.6/linux/oc.tar.gz

We should allow users to input fuzzy versions.

IE 3 should result in the the latest oc 3.x.y.
3.11 should result in the latest 3.11.x.

however this would require some effort to lookup the available versions on the download site and filter through them.

Version

https://github.com/redhat-actions/oc-installer/releases/tag/v1

Describe the bug

The GitHub Actions workflow gives the following warning while running the action:

Node.js 12 actions are deprecated. For more information see: github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12.

Steps to reproduce, workflow links, screenshots

To run the workflow in a standard way without different integrations.

Similar to redhat-actions/push-to-registry#51

Since this morning we receive the following error and our builds are no longer triggered:

Unable to resolve action redhat-actions/oc-installer@v1, unable to find version v1

This is our GitHub workflow:

name: Continuous deployment

on:
  workflow_dispatch:
  repository_dispatch:
  push:
    branches: [master]
  pull_request:
    branches: [master]

jobs:
  build:
    runs-on: ubuntu-latest
    steps:
      # Run OpenShift build process
      - name: Install oc
        uses: redhat-actions/oc-installer@v1
        with:
          oc_version: '3.11.230'         
      - name: Execute oc commands
        run: |
          oc login --insecure-skip-tls-verify --token ${{ secrets.OPENSHIFT_API_TOKEN }} ${{ secrets.OPENSHIFT_SERVER_URL }}
          oc project hip
          oc start-build backend-graphql-server --follow

Is there something we need to change?

It points to the latest build, not the latest release
change it to https://mirror.openshift.com/pub/openshift-v4/clients/ocp/latest/