redblobgames / dual-mesh Goto Github PK

Dear RedBlobGames, i was wondering if you could add a MIT license to this code so that we can legally use it?

For very large maps, we could save a lot of memory by putting the vertex positions into a flat typedarray. First step: move the positions to accessor methods r_x, r_y, t_x, t_y, and then we can change the representation.

The create module combines:

1. poisson disk point selection
2. boundary point selection
3. sanity checks
4. ghost region/side/triangle creation

But all of these aren't always needed.

• If using a pre-selected set of points, they need ghost creation but not the rest
• Sometimes boundary points aren't needed with the poisson disk points
• Sometimes boundary points are needed with the pre-selected points, but the module also inserts poisson disk points when there are boundary points

These should be split up so that the caller can choose which are needed.

Right now the library assumes the points will be 0 ≤ x ≤ 1000, 0 ≤ y ≤ 1000. What does this buy me? Is there any advantage to this limitation, or is just because that's the range I used for the map project this library came from?

create:checkTriangleInequality checks for skinny triangles but doesn't do anything about them. Insert new points at the circumcenters (I think) to eliminate most/all of the skinny triangles.

I use ghost elements for my projects but it might be nice if the library didn't assume they were there.

• _r_any_s array should have incoming edges instead of outgoing
• _r_any_s array should have leftmost edge instead of any edge
• r_circulate_* functions need to be updated to use incoming/outgoing instead of outgoing/incoming, and also check for -1
• make ghost step optional in creation api
• have a boolean function to test if a point is on the convex hull, _r_any_s[r] == -1

Ghost elements are useful to create even if not using the rest of create.js. This should be made available somehow, without the [500,500] hard-coded ghost point.