Code Monkey home page Code Monkey logo

Comments (6)

receyuki avatar receyuki commented on August 23, 2024

This is not a bug. Since I borrowed the entire seed generator from rgthree, my understanding is that it works by storing the seed in a location that is not part of the workflow. Therefore, to implement this feature technically, I would need to rewrite rgthree’s seed generator (something I don’t believe is worthwhile doing).
Alternatively, you could ask rgthree if he would be interested in modifying it to suit your preferences, and then I could learn from his updated code lol.

from comfyui-prompt-reader-node.

alessandroperilli avatar alessandroperilli commented on August 23, 2024

I'd be happy to do that, but are we sure? I perfectly remembered that dragging a previously-generated image into the ComfyUI canvas would load the seed number inside the SDParametersGenerator node without issues.
And I have one AP Workflow user who tells me it used to work fine with AP Workflow 6.0 and now it's not working with 7.0.

Given that I changed absolutely nothing in the workflow about the seed in the transition from 6 to 7, and given the behaviour I just described above, I thought something changed in the node itself.

I have no idea how this feature is implemented. Is it possible that @rgthree changed something in his custom node suite and that impacted the behavior of your SDParametersGenerator node? (Sorry if it's a stupid question)

from comfyui-prompt-reader-node.

alessandroperilli avatar alessandroperilli commented on August 23, 2024

It's working now... I just tried again and the seed loads without issues, as usual. I have no idea what's happening :)

from comfyui-prompt-reader-node.

alessandroperilli avatar alessandroperilli commented on August 23, 2024

I'm closing this for the time being.

from comfyui-prompt-reader-node.

receyuki avatar receyuki commented on August 23, 2024

You're right, I will go over rgthree's code again carefully. His code works perfectly, the problem should be with my modifications.

from comfyui-prompt-reader-node.

alessandroperilli avatar alessandroperilli commented on August 23, 2024

Thank you for fixing this!

from comfyui-prompt-reader-node.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.