Code Monkey home page Code Monkey logo

Comments (13)

receyuki avatar receyuki commented on July 21, 2024

Everything is working fine on my end. I also checked the latest updates for ComfyUI, and it doesn't seem like there are any commits related to KSampler. My suggestion is to restart the ComfyUI, refresh the webpage, and delete and re-add both nodes.
截屏2024-06-30 上午1 49 12

from comfyui-prompt-reader-node.

robertwaleda avatar robertwaleda commented on July 21, 2024

Unfortunately I have the same issue. Sometimes the connection between SD Parameter generator and a KSampler is not possible. But then with another tryout, it is connected. Then when running a queue, no scheduler input at Sampler (red circle). I have found that the scheduler output of the SD Parameter Generator is not present. If I change the scheduler input widget from KSampler back, and choose a scheduler name, then Sampler is working fine. So my first impression is that this is a bug within SD Parameter Generator, using the most recent updated ComfyUI. I have already re-added the node, but problem still exists. For the record, I have a Mac Studio M2 Max.

from comfyui-prompt-reader-node.

jinxishe avatar jinxishe commented on July 21, 2024

I forgot where I saw it, but it seems that a recent update to ComfyUI made adjustments to scheduler-related functions. All custom nodes involving the scheduler might need some modifications. However, I can't remember the specific details, so I apologize for that.

Everything is working fine on my end. I also checked the latest updates for ComfyUI, and it doesn't seem like there are any commits related to KSampler. My suggestion is to restart the ComfyUI, refresh the webpage, and delete and re-add both nodes. 截屏2024-06-30 上午1 49 12

from comfyui-prompt-reader-node.

receyuki avatar receyuki commented on July 21, 2024

@robertwaleda @jinxishe
Have any other custom nodes had similar issues recently? I can’t figure out what the problem is.

from comfyui-prompt-reader-node.

jinxishe avatar jinxishe commented on July 21, 2024

@robertwaleda @jinxishe Have any other custom nodes had similar issues recently? I can’t figure out what the problem is.

yes. other custom nodes like Impact Scheduler Adapter(from Impact Pack) and XY Input:Sampler/Scheduler(from Efficiency Node) have same problems.

3207ece2-2a66-4e14-a86c-e11f7250ce34

from comfyui-prompt-reader-node.

jinxishe avatar jinxishe commented on July 21, 2024

@robertwaleda @jinxishe Have any other custom nodes had similar issues recently? I can’t figure out what the problem is.

yes. other custom nodes like Impact Scheduler Adapter(from Impact Pack) and XY Input:Sampler/Scheduler(from Efficiency Node) have same problems.

3207ece2-2a66-4e14-a86c-e11f7250ce34

from comfyui-prompt-reader-node.

receyuki avatar receyuki commented on July 21, 2024

@robertwaleda @jinxishe Have any other custom nodes had similar issues recently? I can’t figure out what the problem is.

yes. other custom nodes like Impact Scheduler Adapter(from Impact Pack) and XY Input:Sampler/Scheduler(from Efficiency Node) have same problems.

3207ece2-2a66-4e14-a86c-e11f7250ce34

If the authors of these nodes can figure out the problem and solution, I should be able to use it as a reference.

from comfyui-prompt-reader-node.

jinxishe avatar jinxishe commented on July 21, 2024

@robertwaleda @jinxishe Have any other custom nodes had similar issues recently? I can’t figure out what the problem is.

yes. other custom nodes like Impact Scheduler Adapter(from Impact Pack) and XY Input:Sampler/Scheduler(from Efficiency Node) have same problems.
3207ece2-2a66-4e14-a86c-e11f7250ce34

If the authors of these nodes can figure out the problem and solution, I should be able to use it as a reference.

I got some interesting result. When I disabled the Efficiency Node, the problem disappeared. Seems like the AYS-xxxx schedulers added by Efficiency Node caused the problem. I will check the Efficiency Node's issues. Thanks a lot!

from comfyui-prompt-reader-node.

jinxishe avatar jinxishe commented on July 21, 2024

I confirmed it's the Efficiency Node's bug. And it's been fixed recently.(jags111/efficiency-nodes-comfyui#210) After update to newest code, everything is OK now.
Thanks again. I'll close this issue.

from comfyui-prompt-reader-node.

jinxishe avatar jinxishe commented on July 21, 2024

Unfortunately I have the same issue. Sometimes the connection between SD Parameter generator and a KSampler is not possible. But then with another tryout, it is connected. Then when running a queue, no scheduler input at Sampler (red circle). I have found that the scheduler output of the SD Parameter Generator is not present. If I change the scheduler input widget from KSampler back, and choose a scheduler name, then Sampler is working fine. So my first impression is that this is a bug within SD Parameter Generator, using the most recent updated ComfyUI. I have already re-added the node, but problem still exists. For the record, I have a Mac Studio M2 Max.

If you used the Efficiency Node, try to update to newest code and it should fix the problem.

from comfyui-prompt-reader-node.

receyuki avatar receyuki commented on July 21, 2024

Looks like my version of Efficiency Node is too old, which is why this bug didn't appear.

from comfyui-prompt-reader-node.

robertwaleda avatar robertwaleda commented on July 21, 2024

Just tested the scheduler connection between SD Parameter Generator and the KSampler from Efficiency Nodes. The issue is still present. As a temporary workaround, I now use the native scheduler from the KSampler node, as this is also advised by the maintainer ( see jags111/efficiency-nodes-comfyui#208 ). So I think that this case can be closed, because in fact it has to be addressed as an issue with Efficiency Nodes. Thanks for your help.

from comfyui-prompt-reader-node.

robertwaleda avatar robertwaleda commented on July 21, 2024

Extra info: The last update of the Efficiency nodes on my Mac has been done on June 24th. So I suppose that the 210 patch is included.

from comfyui-prompt-reader-node.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.