Comments (6)
Nevermind. This is not related to SD Parameter Generator:
comfyanonymous/ComfyUI#1933
from comfyui-prompt-reader-node.
I'd like to add some additional details to this issue, just for transparency:
After reading the link I posted above, and some testing, I saw that the LCM sampler generates the error simply because the LCM and LCM-LoRA models come with the diffusers format.
To load them, you need one or two nodes, as I quickly implemented here:
![Screenshot 2023-11-16 at 20 07 42](https://private-user-images.githubusercontent.com/9775949/283582145-917c99fd-218e-4621-ba89-3375e4a213e1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM5MjYxNzEsIm5iZiI6MTcyMzkyNTg3MSwicGF0aCI6Ii85Nzc1OTQ5LzI4MzU4MjE0NS05MTdjOTlmZC0yMThlLTQ2MjEtYmE4OS0zMzc1ZTRhMjEzZTEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgxNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MTdUMjAxNzUxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NWQ4ZTYwNzU2ZDFjNmY3NDIyMWQwODZkMzNkODZmNmEwNjc3MDExOGRmYTYxM2M1NTJiM2I5Mzc3ZTM4Nzk1MCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.x8C6tvhKcpSAy5ZBHt4jtHZsI5ofmOlb-jmEe1dpaVk)
So, perhaps, the SD Parameter Generator could do this.
On the other hand, I'm concerned that it might stretch the scope of this node too much and force you to implement too many things. Also, personally, the quality of the images I get with LCM is very low (maybe I'm doing something wrong), so I'm not 100% sure it's worth the effort.
To me, it's a nice-to-have, not a must-have, and definitely much lower priority than the other things I submitted so far.
from comfyui-prompt-reader-node.
I’ve recently been busy with other things, so could you tell me which of these 6 feature requests you’ve mentioned are more urgent, so I can add them asap, while the rest may need to wait for a while. About the LCM sampler, I may need to do some search before I can make decisions, since it is new knowledge to me.
from comfyui-prompt-reader-node.
In order of priority, I'd say:
But it's entirely up to you. I'd go for the easiest to implement, to have a series of quick wins :)
Thank you, as usual.
from comfyui-prompt-reader-node.
I have decided not to include LCM-related features for now.
In terms of development difficulty, this would be a simple copy-paste job as official support for LCM is already in place, thus the problem doesn't lie here.
Based on my understanding, LCM is not currently mainstream, and the number of LCM models is very limited. I believe users who currently use LCM have the capability to figure out how to load LCM models through other nodes. Since LCM models are UNET models, users would still need to load regular checkpoints to provide CLIP models, and they would also need additional specific parameters, which would significantly increase the complexity of the Generator.
I have completed all the features except for LCM support in the dev branch. My current plan is to try writing batch support as mentioned in #13. If this takes some time, I will merge the completed parts into the main branch first.
from comfyui-prompt-reader-node.
I think it's a good decision. Given that LCM-LoRA can be applied transparently to existing workflows, it's possible that very few people will look for the actual LCM models. For them, I'll simply show how to patch AP Workflow.
from comfyui-prompt-reader-node.
Related Issues (20)
- [BUG] - Civitai not recognizing resources HOT 1
- [BUG] - Image batches failing HOT 5
- [BUG] - Error occurred when executing SDPromptReader HOT 1
- [BUG] - Failed to install HOT 4
- SDParameterGenerator's compatibility with ComfyUI Browser's XYZ Plot HOT 4
- [FEATURE REQUEST] - Embed the latent image in the PNG HOT 1
- [FEATURE REQUEST] - Custom Field to save custom info into the PNG HOT 1
- Import failed HOT 6
- [FEATURE REQUEST] - Some limitations when using the Prompt Saver HOT 5
- [BUG] - It seems like Civita.com have change their Meta Data reader for ComfyUI? - all boxes (prompt etc) are blank when uploading. HOT 1
- Workflow can no longer be loaded after update HOT 4
- node error HOT 1
- [BUG] - SD Prompt Saver - Time format filename issue HOT 3
- [BUG] - the scheduler from SD Parameter Generator cannot connect to Ksampler or any other node which has scheduler as an input HOT 13
- Custom resolution enforces step 8 but with 1 as the minimum, meaning its impossible to choose standard resolutions HOT 3
- [FEATURE REQUEST] - Separate Sampler and Scheuler from SD Parameter Extractor HOT 1
- [FEATURE REQUEST] - add denoise to parameter generator and saver
- [BUG] - Can't connect text or string types to positive or negative inputs HOT 2
- [BUG] - SDParameterGenerator error "Value not in list: aspect_ratio"
- [BUG] - When using the latest code of ComfyUI, the SD Parameter Extractor node reports an error.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from comfyui-prompt-reader-node.