Comments (5)
I would offer to send a pull request for the core code, but it's not really possible to fix the problem for users that are not notified about this change, because they will need to check the return value of a function that previously did not return a value.
Affected APIs would be:
rcAddSpan
rcAddSpans
rcRasterizeTriangle
rcRasterizeTriangles (3 overloads)
They all have a "ctx" parameter for error reporting though, so it would only affect the return value change from void to bool.
from recastnavigation.
Hi,
I think it is ok to add return bool value and add an error message on those
functions to indicate that they have failed. It should not break any
current code, but allows people to catch it if needed.
--mikko
On Mon, Jun 22, 2015 at 6:50 PM, rafzi [email protected] wrote:
I would offer to send a pull request for the core code, but it's not
really possible to fix the problem for users that are not notified about
this change, because they will need to check the return value of a function
that previously did not return a value.Affected APIs would be:
rcAddSpan
rcAddSpans
rcRasterizeTriangle
rcRasterizeTriangles (3 overloads)They all have a "ctx" parameter for error reporting though, so it would
only affect the return value change from void to bool.—
Reply to this email directly or view it on GitHub
#100 (comment)
.
from recastnavigation.
@rafzi Did #102 complete everything you wanted to do with this? Are we ok to close this issue?
from recastnavigation.
Yes, this is done.
from recastnavigation.
Great - thanks!
On 31 Dec 2015 1:53 am, "rafzi" [email protected] wrote:
Yes, this is done.
—
Reply to this email directly or view it on GitHub
#100 (comment)
.
from recastnavigation.
Related Issues (20)
- Inconsistent naming of HeightField and Heightfield across the codebase
- Typedef integer flag types as appropriate
- Why use dtMathFloorf to calculate tx1/ty1 (max_x/max_y) but not dtMathCeilf in dtTileCache::queryTiles HOT 1
- Bug when culling out off-mesh start locations?
- Infinite loop in triangulateHull when detailSampleDist == 0
- Small optimizations for CalculateDistanceField() in RecastRegion.cpp HOT 1
- Nullptr dereference leading to a crash in closestPointOnDetailEdges<true> HOT 2
- TempObstacles problem on stair HOT 1
- Can I add Android, IOS, and Linux libraries?
- The "min region size" does not take effect when constructing the navmesh using the TempObstacles mode. HOT 2
- Triangles looks strange. HOT 2
- [Detour] Incorrect layout of tile links in DT_POLYREF64 mode HOT 3
- cannot load new geometry file in RecastDemo HOT 1
- rcFilterLowHangingWalkableObstacles Study HOT 2
- Add revision to the generated navmesh HOT 1
- maxTiles value in the navmesh initialization parameters HOT 1
- dividePoly crashes on the attempt to add 8th point HOT 2
- Bug while loading vertices/indices HOT 4
- [Github Action] Segmentation fault, process completed with exit code 139 HOT 2
- Unable to Export Off-Mesh Links in recastdemo Temp Obstacles HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from recastnavigation.