Code Monkey home page Code Monkey logo

Comments (5)

STRML avatar STRML commented on May 18, 2024

I mean to convert react-resizable to React.cloneElement. I have push access to react-draggable and I've already updated it (see 0.5.0).

from react-grid-layout.

 avatar commented on May 18, 2024

Great!

I noticed that you previously converted react-resizable to React.cloneElement, but then undid it (because of problems with style and className). I tried my hand at it, passing in style and className manually, but I must be misunderstanding how React.cloneElement is different from cloneWithProps (maybe it's the way children are handled?).

Thanks again for all of your fabulous work on each of these libraries.

from react-grid-layout.

STRML avatar STRML commented on May 18, 2024

Yeah, the issue is that cloneWithProps actually properly merges style and className, but cloneElement does not. But cloneElement properly preserves key and ref.

I'm going to try converting again as I've been able to get react-draggable working properly. I'm building a simple helper that makes React.cloneElement behave properly again.

from react-grid-layout.

STRML avatar STRML commented on May 18, 2024

Looks like the latest updates I made to react-draggable and react-resizable have fixed the issues. I'm seeing the proper animations in the old fiddle.

Please reopen if you have any other questions about it.

from react-grid-layout.

 avatar commented on May 18, 2024

Yes! Thank you so much! 👍

from react-grid-layout.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.