Code Monkey home page Code Monkey logo

Comments (3)

gaofanni avatar gaofanni commented on June 2, 2024 1

using 1.4.3

from react-grid-layout.

dkireeti avatar dkireeti commented on June 2, 2024

is this observed when the JS out compile module to be commonJS in babel or webpack config ?

from react-grid-layout.

stuckj avatar stuckj commented on June 2, 2024

We're hitting this too. The problem is the optional chaining operator (i.e., ?'s) usage in the JS output. Line 360 in ReactGridLayout.js, for example looks like this in 1.4.3:

      !((_e$nativeEvent$target = e.nativeEvent.target) !== null && _e$nativeEvent$target !== void 0 && _e$nativeEvent$target.classList.contains(layoutClassName))) {

and this in 1.4.4:

      !e.nativeEvent.target?.classList.contains(layoutClassName)) {

The former looks like babel output handling an optional in vanilla JS whereas the latter is leaving the optional chaining in. If you're targeting pre-ES2020 (or using an older browser) it will barf on this.

Perhaps this was from the node version switch from 16 -> 18? That looks like the biggest change in the diff: 1.4.3...1.4.4.

Maybe this shouldn't be a patch release?

from react-grid-layout.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.