Comments (8)
use ES6 with Babel
would be better.
from progress.
No, just follow the convention, thanks.
from progress.
In the current project we use some es6 features without transpiling it into a production build, should we be doing that in the future?
Actually, when we run npm run pub
, it will compile ES6 to ES5.
Mixins are no longer supported/recommended so I moved away from that, and was unsure whether it was necessary to use a HOC called Shape or something to reduce code duplication or just have the componentDidUpdate method in both Line and Circle.
How about an Inheritance Inversion HOC?
rc-tools complains about prop-types not being a dependency of the project when running the linter. Is there a way around this other than making it a dependency rather than a devDependency
prop-types
should be dependencies, for rc-process supports React@<=15.4
, and developers should not know prop-types
if they use React@<=15.4
from progress.
@wemyss bravo π
from progress.
How about a PR @wemyss
from progress.
@benjycui starting work on this tomorrow πΈ
from progress.
Thoughts on using flow over proptypes?
from progress.
That's what I did. I've made majority of the changes on my fork @ https://github.com/wemyss/progress but I have a few questions:
- In the current project we use some es6 features without transpiling it into a production build, should we be doing that in the future?
- Mixins are no longer supported/recommended so I moved away from that, and was unsure whether it was necessary to use a HOC called
Shape
or something to reduce code duplication or just have thecomponentDidUpdate
method in bothLine
andCircle
. rc-tools
complains aboutprop-types
not being a dependency of the project when running the linter. Is there a way around this other than making it a dependency rather than a devDependency
from progress.
Related Issues (20)
- ζΈεεδΈθ½ε¨ζΈεθ‘ιι’η¨ε
- Option to Add Title and Icon
- [Feature Request] Allow inserting a custom component in the centre of circular progress
- Module not found: Error: Can't resolve 'rc-util/es/Dom/canUseDom' HOT 1
- ChainAlert: new npm maintainer has published version 3.2.4 of package rc-progress HOT 1
- rc progress bar not appearing in the iphone and ipad devices HOT 1
- Gradient for Line component
- New version fills the bar a bit for 0 percentage HOT 1
- Progress bar indefinite mode
- No parameter for adding a border style
- onHover Functionality
- TrailWidth taking default 1, not matching strokeWidth.
- Warning: Circle: Support for defaultProps will be removed from function components in a future major release.
- circle flickers
- scss file
- didn't accept dynamic color value.
- Can we lose the animation for reduced motion setting HOT 1
- Indeterminate Value HOT 7
- missing rc-progress/assets/index.css HOT 2
- Incorrect progress percentage HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from progress.