Code Monkey home page Code Monkey logo

Comments (8)

afc163 avatar afc163 commented on May 23, 2024 1

use ES6 with Babel would be better.

from progress.

benjycui avatar benjycui commented on May 23, 2024 1

No, just follow the convention, thanks.

from progress.

benjycui avatar benjycui commented on May 23, 2024 1

In the current project we use some es6 features without transpiling it into a production build, should we be doing that in the future?

Actually, when we run npm run pub, it will compile ES6 to ES5.

Mixins are no longer supported/recommended so I moved away from that, and was unsure whether it was necessary to use a HOC called Shape or something to reduce code duplication or just have the componentDidUpdate method in both Line and Circle.

How about an Inheritance Inversion HOC?

rc-tools complains about prop-types not being a dependency of the project when running the linter. Is there a way around this other than making it a dependency rather than a devDependency

prop-types should be dependencies, for rc-process supports React@<=15.4, and developers should not know prop-types if they use React@<=15.4

from progress.

benjycui avatar benjycui commented on May 23, 2024 1

@wemyss bravo πŸ‘

from progress.

benjycui avatar benjycui commented on May 23, 2024

How about a PR @wemyss

from progress.

wemyss avatar wemyss commented on May 23, 2024

@benjycui starting work on this tomorrow 😸

from progress.

wemyss avatar wemyss commented on May 23, 2024

Thoughts on using flow over proptypes?

from progress.

wemyss avatar wemyss commented on May 23, 2024

That's what I did. I've made majority of the changes on my fork @ https://github.com/wemyss/progress but I have a few questions:

  • In the current project we use some es6 features without transpiling it into a production build, should we be doing that in the future?
  • Mixins are no longer supported/recommended so I moved away from that, and was unsure whether it was necessary to use a HOC called Shape or something to reduce code duplication or just have the componentDidUpdate method in both Line and Circle.
  • rc-tools complains about prop-types not being a dependency of the project when running the linter. Is there a way around this other than making it a dependency rather than a devDependency

from progress.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.