Code Monkey home page Code Monkey logo

Comments (37)

Razzmatazzz avatar Razzmatazzz commented on September 6, 2024 1

This is related to an issue wherein injectable events do not always appear in the area they should in the save file. The analyzer attempts to insert them where they should be, but it isn't always possible to accurately insert them.

from remnantsaveguardian.

sinnoaria avatar sinnoaria commented on September 6, 2024

image
Not sure if it belongs here, but highlights are hiding the name of the items and custodian is duplicated with one in phantom wasteland and one in generic nerud.

Also, N'Erud: Towers_Test shows up for The Astropath. and N'Erud: Underground_Infection shows up where the Inert Overcharger is. N'Erud: Underground_Stasis for Abomination.

Edit: also N'Erud: Overworld_Zone2 for the second area (not sure which one)

from remnantsaveguardian.

Razzmatazzz avatar Razzmatazzz commented on September 6, 2024

What other events show up in Underground_Infection and Underground_Stasis?

from remnantsaveguardian.

sinnoaria avatar sinnoaria commented on September 6, 2024

What other events show up in Underground_Infection and Underground_Stasis?

I can't remember for underground infection, but I have underground stasis a few times.
One world:
image
Another world:
image
Another world:
image
And one last world:
image

from remnantsaveguardian.

Razzmatazzz avatar Razzmatazzz commented on September 6, 2024

These should all be fixed in the next version. Except probably the duplication as that's an ongoing issue.

from remnantsaveguardian.

sinnoaria avatar sinnoaria commented on September 6, 2024

image
(This is a duplicated entry where the other entry makes sense)

Not sure if this counts, but Morrow Parish is the location and I see the Booster Ring. The guardian lists it as being in the Oracle's Refuge (Which is a sub-area of Morrow Parish) and Oracle's Refuge is the closest world stone (Morrow Sanatorium world stone is technically just a little bit closer physically). Just mentioning it in case it wasn't intentional.

Also, Fae Bruiser Ring was in Ironborough near the Hewdas Clock stone, but is listed as being in Lemark District. The clocktower event (Hewdas Clock) is also listed as being in the Lemark District.

Amulet: One-Eyed Joker and Shaed Bloom Crystal are in the opposite area you start in. (Mine have been in Malefic Palace each time as I started in Beatific Palace each time).

from remnantsaveguardian.

Dom-1 avatar Dom-1 commented on September 6, 2024

Shotgun should (probably?) be renamed "Ford's Scattergun". Right now it leads to 404 when looking for it on the wiki.
https://remnant2.wiki.fextralife.com/Ford's+Scattergun

from remnantsaveguardian.

Razzmatazzz avatar Razzmatazzz commented on September 6, 2024

It might also be the coach gun. Need to know what each is called in the game files.

from remnantsaveguardian.

Dom-1 avatar Dom-1 commented on September 6, 2024

I am specifically talking about the "Shotgun" entry at the Red Throne in Yaesha.
That is definately "Ford's Scattergun".

Edit: The armor set that is called "Armor_Arcanist (XY)" in the program is called Labyrinth in the game.
https://remnant2.wiki.fextralife.com/Labyrinth+Set

Edit2: Ring_BandOfAccord should probably be renamed and link to the correct page on the wiki.
https://remnant2.wiki.fextralife.com/Band+of+Accord

from remnantsaveguardian.

crackedmind avatar crackedmind commented on September 6, 2024

Shotgun should (probably?) be renamed "Ford's Scattergun". Right now it leads to 404 when looking for it on the wiki. https://remnant2.wiki.fextralife.com/Ford's+Scattergun

I checked game resources, and you're right.

I am specifically talking about the "Shotgun" entry at the Red Throne in Yaesha. That is definately "Ford's Scattergun".

Edit: The armor set that is called "Armor_Arcanist (XY)" in the program is called Labyrinth in the game. https://remnant2.wiki.fextralife.com/Labyrinth+Set

Edit2: Ring_BandOfAccord should probably be renamed and link to the correct page on the wiki. https://remnant2.wiki.fextralife.com/Band+of+Accord

I updated this here #86

from remnantsaveguardian.

AndrewSav avatar AndrewSav commented on September 6, 2024

Invader armor as reported by RemnantSaveGuardian is called Dendroid armor in-game.

from remnantsaveguardian.

crackedmind avatar crackedmind commented on September 6, 2024

Invader armor as reported by RemnantSaveGuardian is called Dendroid armor in-game.

Updated in PR. Waiting for merge.

from remnantsaveguardian.

AndrewSav avatar AndrewSav commented on September 6, 2024

2023-08-15_23-33-29

So all these are in The Withering Weald, not in the Far Woods. The Withering Weald in this adventure save is the first overworld zone and it has the Flautist, The Far Woods in the second overworld zone, and these events are not in it.

data.zip

save_1 (second char) adventure mode.

This seems too optimistic.

Edit
I'm not sure if it helps, but what worked for me most of the time (but not always) was to search back from the SpawnTable string to previous /Game/World_???/Quests string, then find next string (forward) that looks like a 32-characters hex number, e.g. AA6CDA7344E047CB7488BA97C565A759, e.g. [0-9,A-F]{32}\x00.{4}(?<loc>.+?)\x00 and take the string (forward) after that. This is usually a waypoint name (not an area name) but that waypoint usually is most relevant. Not bullet proof, but could help combined with other methods.
2023-08-16_00-04-17

from remnantsaveguardian.

Razzmatazzz avatar Razzmatazzz commented on September 6, 2024

I initially used the method of pulling location names directly from the save files, but it wasn't correct in some instances. I'm not too inclined to go back to it given the amount of reports of inaccuracies it generated.

from remnantsaveguardian.

AndrewSav avatar AndrewSav commented on September 6, 2024

@Razzmatazzz I think it would be possible to find middle ground. If you are sure that the location is fixed, then fine, but in case such as I reported the location can change which cause it to be wrong which causes the inaccuracy. Surely changing it for those cases cannot make it worse?

from remnantsaveguardian.

Razzmatazzz avatar Razzmatazzz commented on September 6, 2024

I'm not saying the location is always correct. It isn't. I'm saying pulling the location name text directly out of the save files can also be inaccurate. May be possible to use manual location names when there's a known 1:1 association between events and locations and then use the text from the save file for instances where an event can occur in multiple locations.

from remnantsaveguardian.

Razzmatazzz avatar Razzmatazzz commented on September 6, 2024

This build attempts to combine both methods of determining locations:

RemnantSaveGuardian.zip

from remnantsaveguardian.

GitBooSTid avatar GitBooSTid commented on September 6, 2024

ChimneyApp
"Yaesha: Laemirs' Lyceum" should be "Yaesha: The Chimney"

It's also missing the ring "Berserker's Crest"
Berserker's Crest - Wiki
Chimney

from remnantsaveguardian.

Razzmatazzz avatar Razzmatazzz commented on September 6, 2024

@GitBooSTid can you please post your save (profile and world)? I want to see if there's an event for the coffin.

Edit: nevermind, I see it's part of the Rot event.

from remnantsaveguardian.

GitBooSTid avatar GitBooSTid commented on September 6, 2024

@Razzmatazzz In case you still want it for whatever reason -- Save.zip

from remnantsaveguardian.

Razzmatazzz avatar Razzmatazzz commented on September 6, 2024

@GitBooSTid and this save is from the same campaign roll as above? It's strange because I'm seeing completely different events in The Chimney.

from remnantsaveguardian.

GitBooSTid avatar GitBooSTid commented on September 6, 2024

Yes, but in the above, I was showing you a screenshot from the adventure tab, not campaign. I have The Chimney in both campaign and adventure at the moment.

from remnantsaveguardian.

Razzmatazzz avatar Razzmatazzz commented on September 6, 2024

Ah, got it. This should be working right in the latest release.

from remnantsaveguardian.

AndrewSav avatar AndrewSav commented on September 6, 2024

This build attempts to combine both methods of determining locations:

RemnantSaveGuardian.zip

Sorry, was not playing a last few days. So yes, this builds displays this item in Withering Weald and the latest (1.0.2.2) displays them in Root Nexus, which is also in Withering Weald so it works for me. Thank you.

from remnantsaveguardian.

AndrewSav avatar AndrewSav commented on September 6, 2024

However, in the last build, Spirit Stone is displayed in The Far woods, the experimental build above showed it correctly in Kaeula's Rest (same save, adventure mode) 2023-08-20_01-19-00
2023-08-20_01-20-15
2023-08-20_01-26-16

Same method I suggested last time would work here.

from remnantsaveguardian.

Razzmatazzz avatar Razzmatazzz commented on September 6, 2024

How it works currently is if the first even in an area has been assigned a location manually, then all events in that area use the manual location. If a location has not been assigned, then it uses the area name present in the save file.

from remnantsaveguardian.

GitBooSTid avatar GitBooSTid commented on September 6, 2024

GreatSewers

The above event/injectable is listed in The Great Sewers, but is only an overworld tile event. For me, this occurred in Ironborough. There is the same event in the underground/sewers tilesets, which I also have in my campaign. This is the same save as I uploaded in this thread previously in my campaign tab.

from remnantsaveguardian.

AndrewSav avatar AndrewSav commented on September 6, 2024

@Razzmatazzz since the experimental build seemed to work fine and the latest one does not may be it's best to do what the experimental one does? I do understand that it's a subtle balancing act and what fixes something breaks other things, but I'm not aware of what the experimental might have broken.

from remnantsaveguardian.

GitBooSTid avatar GitBooSTid commented on September 6, 2024

Ribbon

Not sure if this is one you care about, but you can't get Amulets: Silver Ribbon if "The Statues" appears on Gilded Chambers or Council Chambers tilesets, only if it's in Shattered Gallery or The Great Hall. The inverse is true for the Golden Ribbon.

Plain Ribbon

from remnantsaveguardian.

aescolastico avatar aescolastico commented on September 6, 2024

@GitBooSTid The monster does spawn in the sewers as well. but when it does, it doesnt reward the alchemist crafting material. just spawns you in the area with the alchemist armor set.

from remnantsaveguardian.

GitBooSTid avatar GitBooSTid commented on September 6, 2024

@aescolastico I understand and I even described that in my original post. I assume we're trying to clean this up and only list what is possible... which in this case it is not possible to get "Engrams: Alchemist" in Losomn: The Great Sewers, which is what the app is stating.

from remnantsaveguardian.

aescolastico avatar aescolastico commented on September 6, 2024

@GitBooSTid You misunderstand. I was adding context to your report. I wasnt saying you were wrong. What you showed indeed does not reflect the items location in game. We are in agreement.

from remnantsaveguardian.

DanMartin85 avatar DanMartin85 commented on September 6, 2024

not sure if this is the right spot. but the wiki link for Havigator's Helm goes to a 404 page.

correct link should be: https://remnant2.wiki.fextralife.com/Navigator's+Helm

from remnantsaveguardian.

crackedmind avatar crackedmind commented on September 6, 2024

not sure if this is the right spot. but the wiki link for Havigator's Helm goes to a 404 page.

correct link should be: https://remnant2.wiki.fextralife.com/Navigator's+Helm

Yep, also for Lodestone Crown and Crown of the Red Prince because " Set" added

from remnantsaveguardian.

SveItE avatar SveItE commented on September 6, 2024

Location called "Losomn: Asylum: Asylum: Tormented Asylum" probably doesn't need to be called all that.

Remnant2-Win64-Shipping_9KSBH2IAni

from remnantsaveguardian.

Razzmatazzz avatar Razzmatazzz commented on September 6, 2024

not sure if this is the right spot. but the wiki link for Havigator's Helm goes to a 404 page.
correct link should be: https://remnant2.wiki.fextralife.com/Navigator's+Helm

Yep, also for Lodestone Crown and Crown of the Red Prince because " Set" added

The wiki links for these should be fixed in the latest release.

from remnantsaveguardian.

Razzmatazzz avatar Razzmatazzz commented on September 6, 2024

Location called "Losomn: Asylum: Asylum: Tormented Asylum" probably doesn't need to be called all that.

Yeah, it's redundant, but it also follows the convention for other events of World: Area Name: Event Name. It might be better if it was just Losomn: Asylmy or Losomn: Tormented Asylum, but ¯_(ツ)_/¯

from remnantsaveguardian.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.