Code Monkey home page Code Monkey logo

Comments (9)

puffbro avatar puffbro commented on September 6, 2024 1

image
I notice there's both "Amulet_ShadeBloomCrystal" and "Ring_ShaedBloomCrystal". But Shade bloom crystal ring* (not amulet) doesn't exist afaik.

from remnantsaveguardian.

Razzmatazzz avatar Razzmatazzz commented on September 6, 2024 1

Yes, this will be fixed.

from remnantsaveguardian.

Razzmatazzz avatar Razzmatazzz commented on September 6, 2024 1

This should be fixed in the latest release.

from remnantsaveguardian.

Razzmatazzz avatar Razzmatazzz commented on September 6, 2024

Where is it showing up as a ring? I believe that item's key is /Items/Trinkets/Amulets/ShadeBloomFloret/Amulet_ShadeBloomCrystal, so it should parse correctly to be recognized as an amulet.

from remnantsaveguardian.

Wuxriff avatar Wuxriff commented on September 6, 2024

RSG says it's a ring and it's wrong. Also i discovered that Rebellion Spear isn't listed at all - and I don't have it in my current save. Missing entry in the game.json file perhaps.

from remnantsaveguardian.

Wuxriff avatar Wuxriff commented on September 6, 2024

image
game.json, line 944

from remnantsaveguardian.

Wuxriff avatar Wuxriff commented on September 6, 2024

Something went wrong.

image
image
image
image
image
New vs Old
image

from remnantsaveguardian.

Razzmatazzz avatar Razzmatazzz commented on September 6, 2024

Nothing went wrong. It just isn't pulling location names out of the save file in the same way because the locations were sometimes wrong in the old method.

Now, some locations can be inferred from the events if the association exists in the game.json. But some events can occur in multiple locations. In that event, it uses the "SpawnTable" in the save file for the area name since it's usually somewhat descriptive of the area.

from remnantsaveguardian.

Razzmatazzz avatar Razzmatazzz commented on September 6, 2024

Closing this as Shaed Bloom is fixed and the remaining discussion belongs in #9 .

from remnantsaveguardian.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.