razorhash / pyfmpcloud Goto Github PK

Request OHLC data for a list of symbols in 1 call. i.e:

data=sts.historical_stock_data(['TSLA','AAPL'], start = '2020-05-29', period='5min')

As of pandas 1.1.0 (apparently) pd.read_json() no longer accepts json strings as input, resulting in a "Protocol not known" exception. This breaks safe_read_json(). Details here, including a fix:
from io import StringIO
newdf = pd.read_json(StringIO(temp))

Have tested this, works.

The following does not seem to work:

sts.batch_request_eod_prices(date='2020-04-15')

From reading through the documentation, it appears the API does not support this type of query (though I'm not sure why it wouldn't). From the documentation it seems you can only supply a date if you also supply a list of tickers . Otherwise, you just get all of the EOD prices from the last closing date (without the ability to supply a different date).

Hi, just wanted to make sure that you know that your API key is committed to the repository in /pyfmpcloud/config.ini and it is usable by people installing this library.

Requesting intraday time-series returns Incorrect OHLC data.

i.e: the first 5min bar for ALRN shows:
"date" : "2020-05-29 09:30:00",
"open" : 1.320000000000,
"low" : 1.320000000000,
"high" : 1.320000000000,
"close" : 1.320000000000,
"volume" : 3837788

From many sources (Yahoo, IB, Bloomberg) the values are:
O=1.42, H=1.61, L=1.42, C= 1.53, V=413k

1.42 is the lowest value for the day, not 1.32. That's a +7.5% difference.

Requesting intraday time-series returns wrong volume values.

The issue (I assume): At every bar (1 min here), the volume shows the total shares traded for the whole day. It should show the volume for every 1 bar.

For example, requesting intraday data for the symbol 'MBIO' (by: sts.historical_stock_data('MBIO', start = '2020-05-26', period='1min')) from 9:30 to 11:50 shows 132621187 as the whole shares traded in the day while the volume traded in that timeframe was around 1.5M.

Plot for the dataframe:

I have some pytest test cases developed mostly using the 'demo' apikey are you interested?
there are quite a few cases where the demo line they provide don't work so those tests may not be very accurate.

When I started out I remember reading the free account was 500/mo (at least that is my recollection) which was going to be enough for my very limited usage. However, I checked today and the free limit is now 250 max so doesn't look like I am going to be working with this much.

Looks like you had some thought of supporting financialmanagementprep with the inclusion of it's url in settings.py I might try looking into that.

Hope these test cases are useful.

With company_valuation ticker is supplied as a keyword parameter and with stock_time_series it is a positional parameter. I think for ease of use it would be better to be consistent between the two use positional or keyword for both.

I think it's as simple as line 76 of stock_time_series.py should read "&to="

Hello,

cv.income_statement and cv.cash_flow_statement are showing ValueError when ftype = 'full' is selected.
With ftype = 'growth' its working.

Error Message.pdf
Code.txt

Thank you
pauthi03

company_valuation.py does a ticker.upper() bit crypto.py, stock_time_series.py, and forex.py do not. This should be consistent and I think it should be to uppercase ticker if it was not submitted as company_valuation.py does