raysan5 / rini Goto Github PK

In the implementation of rini_load_config, the function is marked as static. This is preventing it from being used in files other than the one that the implementation is defined in. I believe this is a bug, as the rest of the module's functions are not marked as static, allowing them to be used anywhere.

The issue didn't seem to appear when using C and clang, but it did show up when the rest of the project was C++, and using MSVC, but the issue seems to occur with both C and C++.

I've attached a Reproducible Example to allow you to see the issue.

Environment: Windows 11 22H2 (10.0.22621.1702)
Compiler: MSVC (Microsoft Visual C++) version 19.35.32215
Commit: ef31a3d

To get rini.h to work for me in C++ I had to change line 498 char *buffer_ptr = buffer; to const char *buffer_ptr = buffer; to fix error:

.../rini-main/src/rini.h:498:24: error: invalid conversion from ‘const char*’ to ‘char*’ [-fpermissive]
498 | char *buffer_ptr = buffer;

I think I am doing something wrong but idk, the value delimiter looks hard coded to a ' ' even if u change it to a '=' it won't work and a space will .ini files should work like this as well:KEY=7 ; but rini doesn't so I changed the ' ' to the value delimiter macro and then it does work ig
https://github.com/raysan5/rini/blob/main/src/rini.h#L496 here is the issue start