Code Monkey home page Code Monkey logo

Comments (7)

aRyBernAlTEglOTRO avatar aRyBernAlTEglOTRO commented on July 20, 2024 1

Q: Did you set object_store_memory to a float?
A: Yes, as you can see from the the reproduction script:

 @serve.deployment(ray_actor_options={"object_store_memory": 20 * 1024 * 1024})

I think this line of code is the reason that cause the bug, which convert the value of object_store_memory to float, I think change it from object_store_memory: float to object_store_memory: int will fix this bug.

from ray.

aRyBernAlTEglOTRO avatar aRyBernAlTEglOTRO commented on July 20, 2024

I think this bug is caused by this line of code, after I change the value from _counting_option("object_store_memory", False) to _resource_option("object_store_memory") the error fixed.

from ray.

shrekris-anyscale avatar shrekris-anyscale commented on July 20, 2024

@aRyBernAlTEglOTRO did you set object_store_memory to a float? Or did you set it to an int and then see this error?

It looks like this option is expected to be an int instead of a float (code link). If Serve is converting it to a float, then that sounds like a bug.

from ray.

shrekris-anyscale avatar shrekris-anyscale commented on July 20, 2024

It turns out object_store_memory is not supported in Ray Core (see issue). I'm reopening this issue until we decide how to handle it in Ray Serve.

from ray.

shrekris-anyscale avatar shrekris-anyscale commented on July 20, 2024

@aRyBernAlTEglOTRO We're planning to remove object_store_memory in Ray Serve. The option is not supported in Ray Core, so setting it is a no-op in Serve. Could you explain your use case for object_store_memory, so we can see if there's another way to accomplish it?

from ray.

aRyBernAlTEglOTRO avatar aRyBernAlTEglOTRO commented on July 20, 2024

@shrekris-anyscale Thank you for your effort. The reason that I use object_store_memory is due to that I met some memory leak issue when I used Ray Serve. Therefore I searched around for some parameters which can control the memory usage of deployment, at that time I encontered the object_store_memory, but even after I set this parameter, the memory leak issue still exist.

from ray.

shrekris-anyscale avatar shrekris-anyscale commented on July 20, 2024

Can you file a separate issue for the memory leak? Do you know if it's happening in the Ray Serve code, or the application code?

from ray.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.