Comments (8)
ml054
commented on July 29, 2024
1
Hi, @yj7o5
The POC looks very good! The plan is to have strongly typed javascript indexes under current name: AbstractJavaScriptIndexCreationTask. We can do this in 5.0 (breaking change).
Also we want to expose current AbstractJavaScriptIndexCreationTask under new name (maybe: AbstractRawJavaScriptIndexCreationTask).
Currently I'm working on 5.0 client so once I have some consistent state I can send link to branch.
Another thing we need to check if it will work after you minify code (function names may change).
Please also remember to sign our CLA: https://ravendb.net/contributors/cla/sign
Feel free to continue your work on 4.2 branch. We can rebase your changes on top of 5.0 later.
from ravendb-nodejs-client.
ayende
commented on July 29, 2024
In general, I would absolutely love to have this feature, yes.
Can you send a PR?
…On Thu, Jul 11, 2019 at 5:50 AM Kamran Ayub ***@***.***> wrote:
This is more of a question/suggestion.
Looking at the tests for AbstractJavaScriptIndexCreationTask I'm
wondering if we'll eventually be able to just express the index in raw JS
since we can do Function.toString() to grab the raw definition to store.
Could even provide some TypeScript static typing to help.
Example:
http://www.typescriptlang.org/play/index.html#code/C4TwDgpgBAkgdgEwgDwCIQGYEs5eFgezgB4AVAPigF4oAKBAgYwFcBbCOYALilIEpqlAgCMAVhEbAAUFMYAbAIYBnJVACCwpcABOCyQCkFANwUBlRtqxhg8JMgDC2iAvxFSygNZQA3lKj+oMEsTYGgAfVYFMFUaOAgAdyhTCGBiLUs4AHNyWj4ZAMDtAlDJCAQoSLAyHMYCOTkJVzgedJxMgBooJGxcJp5bFHQevEISCgFfAoLgAAssJQA6CKjFhQQEWgADStoAcgASb1r6xtGAX13Ow+6cEaIF4AJTHTbcs75NvgBuPwCz-ICmRSFRWuR8vymUCcwGY2jgUFm8yWlSUPwK-3+UhwoW0GD00AAqkoINpwQVmMS4Qp2C0Xlk0QEsAhaRlMj9MfJlKoiSSlGEAEIgHlU9hQFChRCqDTpPTAQwmcyWawDBxOFyjdxKLyTAK1ODpZiSAjaME6yFKZiQE15CFTRGLSrEYU5XbCpSXOjMARUSi0bxQCkkuDUiA8ZgLQMi6DvG2Q-x6pR1CALOQETK0e0LFF5dFSDlELRQHB2ahQOKJN0CoWU4PsXJAA
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#208?email_source=notifications&email_token=AAA4RM2IPFO4UFKQCABXRHLP62NVXA5CNFSM4IANRUD2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G6QGXPA>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAA4RMZHJ5DIZSUDJZDZZLTP62NVXANCNFSM4IANRUDQ>
.
--
<https://ravendb.net/> *Oren Eini*
*CEO / Hibernating Rhinos LTD <https://hibernatingrhinos.com/>*
Mobile: +972-52-548-6969
Sales: [email protected]
Skype: ayenderahien
Support: [email protected]
from ravendb-nodejs-client.
yj7o5
commented on July 29, 2024
@ayende If this hasn't been taken care of, would love to send a PR. Thanks
from ravendb-nodejs-client.
ayende
commented on July 29, 2024
Go ahead, would love it!
…On Mon, Oct 12, 2020 at 7:00 AM Yawar Jamal ***@***.***> wrote:
@ayende <https://github.com/ayende> If this hasn't been taken care of,
would love to send a PR. Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#208 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA4RM6DF6RIRI3QG42YKQLSKJ5OFANCNFSM4IANRUDQ>
.
--
<https://ravendb.net/> *Oren Eini*
*CEO / Hibernating Rhinos LTD <https://hibernatingrhinos.com/>*
Mobile: 972-52-548-6969
Sales: [email protected]
Skype: ayenderahien
Support: [email protected]
<https://www.facebook.com/pages/RavenDB/265907650186374>
<https://twitter.com/ravendb>
<https://www.linkedin.com/company/hibernating-rhinos-ltd-/>
<https://ravendb.net/emailsignature/displayeventpage>
from ravendb-nodejs-client.
yj7o5
commented on July 29, 2024
@ayende I haven't opened a PR yet since I have not been able to fully test again a running Raven instance but here's a quick POC I have:
yj7o5@9db45fe
Just wanted to make sure first you like the direction. So few things:
- I removed the old test cases. Do we still want to keep those?
- Any further refinements you'd like to see?
Will do a bit more clean up in the AbstractJavaScriptIndexTask class and make sure I can get the test suite fully running/tested and then create the PR. But so far the output definition matches with the old version.
from ravendb-nodejs-client.
ml054
commented on July 29, 2024
@yj7o5 I'd like to notify that issue: https://issues.hibernatingrhinos.com/issue/RDBC-421 is now in progress. I will be investigating your idea.
from ravendb-nodejs-client.
yj7o5
commented on July 29, 2024
Thanks @ml054 and just let me know if there are any changes required.
from ravendb-nodejs-client.
ml054
commented on July 29, 2024
@yj7o5 implemented as a part of https://github.com/ml054/ravendb-nodejs-client/tree/v5.0
from ravendb-nodejs-client.
Related Issues (20)
- Using load with includes returns null for documents that were previously stored HOT 2
- Cannot find type definition file for 'stream-json' HOT 2
- Issue with 5.0.1 HOT 3
- Map/Reduce in NodeJs HOT 2
- Can I use the as clause? HOT 2
- TimeSeriesRangeAggregation.asTypedEntry not producing expected results HOT 3
- Getting started error HOT 4
- Serialisation issue HOT 2
- load methods could reasonably return null and interface should reflect that HOT 7
- Activating `queryCustomization.randomOrdering` ignores Collection parameter and returns from all Collections HOT 2
- error TS2507: Type 'typeof FilterBase' is not a constructor function type. HOT 8
- Properly handle large requests using multi byte chars
- Provide a way for closing sessions manually HOT 7
- Question: check for unsaved changes in session HOT 1
- Map/Reduce TypeError: Object has no method 'flat' HOT 3
- Incorrect ModifiedDocument returned in afterSaveChanges session event HOT 6
- @nested-object-types doesn’t store type information for newly added fields on update HOT 3
- GetDatabaseOperation throws when response is "successfully" a 404 HOT 9
- Type clash with @types/node HOT 2
- Remove @Metadata when querying HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ravendb-nodejs-client.