Exposition We’re loading existing documents and setting “new” fiel

<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="16

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

@nested-object-types doesn’t store type information for newly added fields on update about ravendb-nodejs-client HOT 3 CLOSED

ravendb commented on September 3, 2024

@nested-object-types doesn’t store type information for newly added fields on update

from ravendb-nodejs-client.

Comments (3)

jhahn commented on September 3, 2024

Did a little more digging.

It looks like a variable scoping issue. When the object key matches the metadata constant (@metadata), skipTypes is clobbered, forever set to true until the recursive function finishes.

ravendb-nodejs-client/src/Mapping/ObjectMapper.ts

Lines 449 to 454 in 70834f6

    
           if (!skipTypes) { 
        
               skipTypes = key === CONSTANTS.Documents.Metadata.KEY; 
        
           } 
        
           const fullPath = objPathPrefix ? `${objPathPrefix}.${nestedTypeInfoKey}` : nestedTypeInfoKey; 
        
           result[key] = this._makeObjectLiteral(obj[key], fullPath, typeInfoCallback, knownTypes, skipTypes);

We were able to work around the issue by making this change:

let innerSkipTypes = skipTypes
if (!skipTypes) {
    innerSkipTypes = key === CONSTANTS.Documents.Metadata.KEY;
}

const fullPath = objPathPrefix ? `${objPathPrefix}.${nestedTypeInfoKey}` : nestedTypeInfoKey;
result[key] = this._makeObjectLiteral(obj[key], fullPath, typeInfoCallback, knownTypes, innerSkipTypes);

from ravendb-nodejs-client.

ml054 commented on September 3, 2024

#357

from ravendb-nodejs-client.

ml054 commented on September 3, 2024

@jhahn Fixed. This for reporting this issue and very clear explanation and solution suggestion.

from ravendb-nodejs-client.

@nested-object-types doesn’t store type information for newly added fields on update about ravendb-nodejs-client HOT 3 CLOSED

Comments (3)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	if (!skipTypes) {
	skipTypes = key === CONSTANTS.Documents.Metadata.KEY;
	}

	const fullPath = objPathPrefix ? `${objPathPrefix}.${nestedTypeInfoKey}` : nestedTypeInfoKey;
	result[key] = this._makeObjectLiteral(obj[key], fullPath, typeInfoCallback, knownTypes, skipTypes);