Code Monkey home page Code Monkey logo

shopware5-module's People

Contributors

annegrets avatar eiriarte-mendez avatar jessica2342 avatar kevinhansen23 avatar martinkuhl avatar mtroesken avatar rommelfreddy avatar rpwelschlau avatar rpwhittington avatar schmittrigger avatar simonzachrau avatar soerenmartius avatar vlkrrhmlw avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

shopware5-module's Issues

Useless broken payment & order status

This lines add empty order and payment status (because the title is missing) that never seems to be used:

255, 'Teil-(Retoure)', 255, 'state', 0

265, 'Teil-(Storno)', 265, 'state', 0

155, 'Zahlungsabwicklung durch RatePAY', 155, 'payment', 0

Wrong namespaces used

The plugin is not compatible with Shopware 5.6

IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- Plugins/Community/Frontend/RpayRatePay/Bootstrapping/Events/TemplateExtensionSubscriber.php	(revision ad74abd88c66236b215bd91b9d26a940be75c5b9)
+++ Plugins/Community/Frontend/RpayRatePay/Bootstrapping/Events/TemplateExtensionSubscriber.php	(date 1571059944562)
@@ -3,8 +3,8 @@
 namespace RpayRatePay\Bootstrapping\Events;
 
 use RpayRatePay\Component\Model\ShopwareCustomerWrapper;
-use Shopware\Plugins\Community\Frontend\RpayRatePay\Services\ConfigService;
-use Shopware\Plugins\Community\Frontend\RpayRatePay\Services\DfpService;
+use RpayRatePay\Services\ConfigService;
+use RpayRatePay\Services\DfpService;
 
 class TemplateExtensionSubscriber implements \Enlight\Event\SubscriberInterface
 {
Index: Plugins/Community/Frontend/RpayRatePay/Bootstrapping/Events/BackendOrderControllerSubscriber.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- Plugins/Community/Frontend/RpayRatePay/Bootstrapping/Events/BackendOrderControllerSubscriber.php	(revision ad74abd88c66236b215bd91b9d26a940be75c5b9)
+++ Plugins/Community/Frontend/RpayRatePay/Bootstrapping/Events/BackendOrderControllerSubscriber.php	(date 1571059929325)
@@ -8,7 +8,7 @@
 use RpayRatePay\Component\Service\Logger;
 use Shopware\Models\Order\Order;
 use RpayRatePay\Component\Service\ConfigLoader;
-use Shopware\Plugins\Community\Frontend\RpayRatePay\Services\DfpService;
+use RpayRatePay\Services\DfpService;
 
 class BackendOrderControllerSubscriber implements \Enlight\Event\SubscriberInterface
 {
Index: Plugins/Community/Frontend/RpayRatePay/Services/DfpService.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- Plugins/Community/Frontend/RpayRatePay/Services/DfpService.php	(revision ad74abd88c66236b215bd91b9d26a940be75c5b9)
+++ Plugins/Community/Frontend/RpayRatePay/Services/DfpService.php	(date 1571059913473)
@@ -1,7 +1,7 @@
 <?php
 
 
-namespace Shopware\Plugins\Community\Frontend\RpayRatePay\Services;
+namespace RpayRatePay\Services;
 
 
 use Shopware\Components\DependencyInjection\Container;
Index: Plugins/Community/Frontend/RpayRatePay/Services/ConfigService.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- Plugins/Community/Frontend/RpayRatePay/Services/ConfigService.php	(revision ad74abd88c66236b215bd91b9d26a940be75c5b9)
+++ Plugins/Community/Frontend/RpayRatePay/Services/ConfigService.php	(date 1571059900427)
@@ -1,15 +1,15 @@
 <?php
 
 
-namespace Shopware\Plugins\Community\Frontend\RpayRatePay\Services;
-
+namespace RpayRatePay\Services;
 
 class ConfigService
 {
 
     //TODO remove if plugin is moved to SW5.2 plugin engine
     private static $instance = null;
-    public static function getInstance(){
+    public static function getInstance()
+    {
         return self::$instance = (self::$instance ? : new self(Shopware()->Config()));
     }
 
@@ -20,10 +20,10 @@
         $this->_config = $config;
     }
 
-    public function getDfpSnippetId() {
+    public function getDfpSnippetId()
+    {
         $defaultValue = 'ratepay';
         $value = $this->_config->get('ratepay/dfp/snippet_id', $defaultValue);
         return strlen($value) ? $value : $defaultValue;
     }
-
 }

RatePay tabpanel creation overrides the Shopware tab

Hello RatePay Team,

We have a Compatibility issue with your Plugin because of the Tab Panel Override method:

Here:

And here:

Basicly you are overriding the whole Shopware tab panel so every Third Party Plugin that want's to add a tab in the Order Window will be overridden with the RateBay tabs.

The solution would be to add the RatePay tabs to the parent tabPanel
tabPanel.add("RATEPAY TAB PANELS");

Deprecated PHP methods used

HowTo
When the shopping cart is confirmed and installment payment is selected, two warnings are displayed. https://www.shopwaredemo.de/checkout/confirm

Errors
Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP; PiRatepayRateCalc has a deprecated constructor in ../Plugins/Community/Frontend/RpayRatePay/Views/responsive/frontend/installment/php/PiRatepayRateCalc.php on line 19

Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP; PiRatepayRateCalcBase has a deprecated constructor in ../Plugins/Community/Frontend/RpayRatePay/Views/responsive/frontend/installment/php/PiRatepayRateCalcBase.php on line 15

Example
The name of a function can not be equal to the name of a class.
class PiRatepayRateCalc extends PiRatepayRateCalcBase{}
public function PiRatepayRateCalc() { parent::PiRatepayRateCalcBase(); }

sandbox

wo finden wir ratepay sandbox?
und überhaupt, ratepay entwickler dokumentation?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.