rapid7 / rex-core Goto Github PK
View Code? Open in Web Editor NEWCreated by David Maloney via the GitHub Connector
License: Other
Created by David Maloney via the GitHub Connector
License: Other
It looks like the Reader/Writer lock isn't thread safe. I haven't investigated the issue further, as there's been no previously raised issues for this in metasploit-framework.
Simple resource script which reads/writes to a file on disk:
<ruby>
# results.txt will be used as an instance counter
# It will be incremented by 1 within a writer lock, and read via reader lock
File.write('./results.txt', '0', mode: 'w')
lock = ::Rex::ReadWriteLock.new
begin
threads = 100.times.map do
Thread.new do
300.times do
if rand > 0.5
lock.synchronize_write do
value = File.read('./results.txt').to_i
File.write('./results.txt', value + 1, mode: 'w')
end
end
lock.synchronize_read do
value = File.read('./results.txt')
end
end
end
end
threads.each(&:join)
ensure
puts "File result: #{File.read('./results.txt')}"
end
</ruby>
Exception:
msf6 exploit(multi/script/web_delivery) > resource resource.rc
[*] Processing /Users/user/Documents/code/metasploit-framework/resource.rc for ERB directives.
[*] resource (/Users/user/Documents/code/metasploit-framework/resource.rc)> Ruby Code (791 bytes)
File result:
[-] resource (/Users/user/Documents/code/metasploit-framework/resource.rc)> Ruby Error: ThreadError Attempt to unlock a mutex which is not locked [
"/Users/user/.rvm/gems/ruby-3.0.2@metasploit-framework/gems/rex-core-0.1.26/lib/rex/sync/read_write_lock.rb:107:in `unlock'",
"/Users/user/.rvm/gems/ruby-3.0.2@metasploit-framework/gems/rex-core-0.1.26/lib/rex/sync/read_write_lock.rb:107:in `ensure in unlock_read'",
"/Users/user/.rvm/gems/ruby-3.0.2@metasploit-framework/gems/rex-core-0.1.26/lib/rex/sync/read_write_lock.rb:107:in `unlock_read'",
"/Users/user/.rvm/gems/ruby-3.0.2@metasploit-framework/gems/rex-core-0.1.26/lib/rex/sync/read_write_lock.rb:152:in `synchronize_read'",
"(eval):18:in `block (3 levels) in load_resource'",
"(eval):10:in `times'", "(eval):10:in `block (2 levels) in load_resource'",
"/Users/user/.rvm/gems/ruby-3.0.2@metasploit-framework/gems/logging-2.3.0/lib/logging/diagnostic_context.rb:474:in `block in create_with_logging_context'"
]
Hi,
I opened an issue for msf because I was having troubles with opening documentation.
Finally, I found out that open_browser()
function were using 'xdg-open'
and 'sensible-browser'
first (which I think is a good thing) but open_webrtc_browser()
uses 'google-chrome'
first.
I've found out two solutions :
open_webrtc_browser()
function by providing 'xdg-open'
and 'sensible-browser'
first (but I'm not sure, as I don't really understand the purpose of this function compared to open_browser()
).open_webrtc_function()
with open_browser()
in order to make it more usable (cf. issue).Could someone tell me what solution in your opinion, is the best ? I'll then make the modifications and make a pull request.
rex-core doesn't have any license.
The same problem affects a few other rex gems.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.