ramkikannan / planc Goto Github PK

this->H = (this->H % AtW) / (this->H * WtW + EPSILON_1EMINUS16);
what is %?

It seems that the comparison being done here always results in the user input being interpreted as a parameter for rand_ rather than an input filename. Overriding the expression with if (true) allows the program to load the matrix as expected.

Hi Ramki,

The lines at

are not generally available in portable builds. The armadillo CMake modules would exist for a local in-place source build of armadillo but are not generally available for builds of PLANC when armadillo is already installed.

I would recommend instead of directly including these modules (ARMA_FindOpenBlas, etc) to rely on CMake's builtin package finding mechanisms, something like ():

set(BLA_VENDOR OpenBLAS)  # force following two lines to look for OpenBlas only
find_package(BLAS REQUIRED)  # Set other constraints as necessary
find_package(LAPACK REQUIRED)

The stock FindBLAS.cmake and FindLAPACK.cmake modules should be quite sufficient (the ARMA_Find* versions shipped with the armadillo source code didn't appear to me to actually do much since OpenBLAS support was added to cmake in version 3.6.0. Their developers should probably up the minimum cmake requirement and drop these custom modules too). One of the things the stock FindBlas module doesn't do is set "${OpenBLAS_FOUND}" which should be unnecessary given BLAS_FOUND and BLA_VENDOR.

If using the stock FindPKG modules is not possible, then the required external custom cmake modules should be shipped with this source code so builds of this don't need to fetch both this and armadillo sources in the case that armadillo is previously installed.