rakyll / trace Goto Github PK

Why does NewSpan return a context? Couldn't the Client store any necessary information in itself?

I think the second arg to Log should be interface{}. Some Clients can fmt.Sprint it if they wish, but others might accept something that doesn't have a String method, maybe something for structured logging. (I'm thinking of cloud.google.com/go/logging.)

Comment for TraceID talks about a "tracer". You mean a Client?

s/acts like a no-op function/does nothing/

SetLabel, line 116: put the new map back into the context. Or maybe you shouldn't create a new map, since a missing labels key means no tracing is happening? I wish the only context key was the Client.

Have you thought about

 func InSpan(context.Context, func())

that will combine WithSpan, calling the function, and Finish?