rajasegar / ember-slide-push-menu Goto Github PK

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• chore(deps): replace dependency eslint-plugin-node with eslint-plugin-n 14.0.0
• chore(deps): replace dependency npm-run-all with npm-run-all2 5.0.0
• chore(deps): update dependency @semantic-release/changelog to v6.0.3
• chore(deps): update dependency ember-auto-import to v1.12.2
• chore(deps): update dependency ember-cli to v3.28.6
• chore(deps): update dependency ember-source to v3.28.12
• fix(deps): update dependency ember-cli-babel to v7.26.11
• fix(deps): update dependency ember-cli-htmlbars to v5.7.2
• chore(deps): update dependency @ember/optional-features to v2.1.0
• chore(deps): update dependency @ember/render-modifiers to v2.1.0
• chore(deps): update dependency ember-cli-dependency-checker to v3.3.2
• chore(deps): update dependency ember-resolver to v8.1.0
• chore(deps): update dependency ember-template-lint to v3.16.0
• chore(deps): update glimmer.js packages to v1.1.2 (@glimmer/component, @glimmer/tracking)
• chore(deps): update actions/checkout action to v4
• chore(deps): update dependency ember-cli to v5
• chore(deps): update dependency ember-cli-code-coverage to v2
• chore(deps): update dependency ember-qunit to v8
• chore(deps): update dependency ember-resolver to v11
• chore(deps): update dependency ember-source to v5
• chore(deps): update dependency ember-template-lint to v5
• chore(deps): update dependency ember-try to v3
• chore(deps): update rwjblue/setup-volta action to v4
• fix(deps): update dependency ember-cli-babel to v8
• 🔐 Create all rate-limited PRs at once 🔐

Other Branches

These updates are pending. To force PRs open, click the checkbox below.

• chore(deps): update dependency webpack to v5.76.0 [security]

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update dependency semantic-release to v19 [security]
• chore(deps): replace dependency babel-eslint with @babel/eslint-parser 7.11.0
• chore(deps): update dependency ember-auto-import to v2
• chore(deps): update dependency eslint to v8
• fix(deps): update dependency ember-cli-htmlbars to v6
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

What is the correct way to specify the width of cbp-spmenu-vertical cbp-spmenu-right?

Thank you!

Seeing this in version 1.0.0 (1.0.1 doesn't seem to be a legit version?). I'm using Ember 3.11.

deprecate.js:120 DEPRECATION: Using Ember.$() has been deprecated, use import jQuery from 'jquery'; instead [deprecation id: ember-views.curly-components.jquery-element] See https://emberjs.com/deprecations/v3.x#toc_jquery-apis for more details. at logDeprecationStackTrace (http://localhost:4200/assets/vendor.js:54731:23) at HANDLERS.<computed> (http://localhost:4200/assets/vendor.js:54825:11) at raiseOnDeprecation (http://localhost:4200/assets/vendor.js:54758:11) at HANDLERS.<computed> (http://localhost:4200/assets/vendor.js:54825:11) at http://localhost:4200/assets/lightworks-tuxedo.js:19533:9 at HANDLERS.<computed> (http://localhost:4200/assets/vendor.js:54825:11) at invoke (http://localhost:4200/assets/vendor.js:54837:11) at deprecate (http://localhost:4200/assets/vendor.js:54796:30) at Object.get [as $] (http://localhost:4200/assets/vendor.js:74910:52)

And if I add a breakpoint at the last frame from the above trace, I am here:

didInsertElement() {
      this._super(...arguments);
      Ember.$('body').addClass('cbp-spmenu-push');
},

Let me know if I can provide any more info!

Our implementation using two slide outs is crashing in IE, however the demo is not. Can you add the demo source code to the repo so we can compare? Thanks!

Hi There,

I just implemented this plug-in and ran into an issue closing the menu when I'm using the push setup. I took a look at the add-on code and it looks like you need something like the following in the esp-menu.js file where you inserted a comment for cleanup:

updateBodyClass() {
    let _bodyClass = this.get('bodyClass');
    if ( this.get('pushMenu') && !$('body').hasClass(_bodyClass) ) {
      $('body').addClass(_bodyClass);
    } else {
      $('body').removeClass(_bodyClass);
    }
  },

That seems to solve the problem for me however I didn't want to submit a PR in case this doesn't fit in with the bigger picture of what you're doing. Lemme know or feel free to update on your end.

When we try to open the push menu while the side menu is already open, the demo behaves weirdly.

Hi @rajasegar ,

thanks for sharing this addon with the Ember-community.
Currently we are using https://github.com/offirgolan/ember-burger-menu .

How does this addon compare to this one here and why would I consider moving over?
Would appreciate your insights here.

Thanks
Andreas