Some commits are missing in the list about rails-contributors HOT 25 CLOSED

hmmm, the mapping works but Bogdan is not in the list yet

from rails-contributors.

This is an edge case in which there is an existing name whose slug matches a new name, by design heuristics try not to be too clever and want to match names exactly. Right now there are 31 comimts without credit (in a total of 68K).

from rails-contributors.

👍

from rails-contributors.

I pushed the map and closed the issue via the commit message, but production needs to catchup. It's live now http://contributors.rubyonrails.org/contributors/bogdan/commits.

from rails-contributors.

@fxn, http://contributors.rubyonrails.org/contributors/bogdan/commits, last commit in list isn't my

from rails-contributors.

i think contributors should be more than 4400, but now 4341.

from rails-contributors.

@bogdanvlviv why do you think so.

from rails-contributors.

@bogdanvlviv Going to revise the map then, assumed from the description it was yours but we really had two issues to address.

from rails-contributors.

i know, this commit contributor should be https://github.com/bogdan, http://contributors.rubyonrails.org/contributors/bogdan-gusiev/commits

from rails-contributors.

i have seen before more than 4400 conributors but now less after rails/rails@8ecc5ab i thnik

from rails-contributors.

@bogdanvlviv in the last weekend the counter was 4363 exactly, but I researched a bunch of aliases on Monday. And more are going to come. New aliases decrease the counter.

from rails-contributors.

New map in production.

from rails-contributors.

@fxn, why don't make path as http://contributors.rubyonrails.org/contributors/GITHUB_USERNAME/commits for all contributors

from rails-contributors.

@bogdanvlviv have a look at the source code of the application and its test suite, this application is not as simple as you might think.

from rails-contributors.

it will be correctly and less problem. before i have path for my commits http://contributors.rubyonrails.org/contributors/BOGDANVLVIV/commits but now http://contributors.rubyonrails.org/contributors/BOGDAN/commits it is confusing? could i have path with 'bogdanvlviv'?

from rails-contributors.

i have incorrect start date contribute "19 Jun 2015" should be "26 Mar 2016"

from rails-contributors.

Absolutely, that is your choice, if you prefer to appear with your handler the application is able to do it. What do you prefer?

from rails-contributors.

(But that means appearing with your handler in the home page as well.)

from rails-contributors.

i prefer "bogdanvlviv"

from rails-contributors.

OK, need to switch tasks now, I'll apply that and check the date later.

from rails-contributors.

@fxn, thanks!

from rails-contributors.

@fxn, could you notify me when it will be done?

from rails-contributors.

I've seen the problem with the date, the app computes first contribution date for new authors, but if later remaps move commits around, these timestamps are not recomputed.

I am working on both things now.

from rails-contributors.

There you go http://contributors.rubyonrails.org/contributors/bogdanvlviv/commits.

The date is also fixed.

from rails-contributors.

Thanks!

from rails-contributors.